Add assert_is() and assert_is_not() #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fantix
commented
Mar 9, 2024
Comment on lines
+74
to
+120
| if a === b { | ||
| Ok(()) | ||
| } else { | ||
| let a = debug_string(a) | ||
| let b = debug_string(b) | ||
| Err("assertion failed for `\(a) === \(b)`") | ||
| } |
There was a problem hiding this comment.
This is preferably @option.unless(a === b, fn() { ... }), but crippled by the lack of test_import in moon.pkg.json, and/or a better handling of cyclic dependencies.
There was a problem hiding this comment.
test_import will be added as soon as next week
3 tasks
Yoorkin
reviewed
Mar 11, 2024
Yoorkin
approved these changes
Mar 11, 2024
|
Embarassingly,
I'll follow up with another PR after working hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should probably introduce a
!==operator ... ?