-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use xxhash for int64 #414
use xxhash for int64 #414
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Pull Request Test Coverage Report for Build 1398Details
💛 - Coveralls |
25e08a8
to
93b4cc6
Compare
If we view a Note that in the future we may wish to expose some internal state API of |
see #409.
The old version of int64 hash will create a lot of collision when the hi and lo part of the int64 ranges over a similar range, and hence the performance degradation seen in #409.
One drawback of this approach is, it allocates a
Bytes
object every time thehash
function is called, but as per my micro-benchmarks they doesn't seems to be affect much.This patch copied the
Int64
to aBytes
then call xxhash internally.