Replace T::[_] with T::of #606

qazxcdswe123 · 2024-06-25T10:01:52Z

Replace T::[_] with T::of

coderabbitai · 2024-06-25T10:01:57Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coveralls · 2024-06-26T03:10:40Z

Pull Request Test Coverage Report for Build 1931

Details

38 of 42 (90.48%) changed or added relevant lines in 13 files are covered.
27 unchanged lines in 9 files lost coverage.
Overall coverage decreased (-0.7%) to 87.963%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
builtin/linked_hash_map.mbt	0	2	0.0%
devec/devec.mbt	0	2	0.0%

Files with Coverage Reduction	New Missed Lines	%
hashmap/hashmap.mbt	2	95.65%
devec/devec.mbt	2	87.5%
immut/sorted_set/immutable_set.mbt	3	91.04%
queue/queue.mbt	3	88.71%
immut/hashmap/HAMT.mbt	3	71.43%
immut/list/list.mbt	3	93.56%
immut/hashset/HAMT.mbt	3	73.85%
immut/priority_queue/priority_queue.mbt	4	84.09%
priority_queue/priority_queue.mbt	4	80.0%

Totals
Change from base Build 1927:	-0.7%
Covered Lines:	3135
Relevant Lines:	3564

💛 - Coveralls

coveralls · 2024-06-26T03:10:48Z

Pull Request Test Coverage Report for Build 1930

Details

38 of 42 (90.48%) changed or added relevant lines in 13 files are covered.
27 unchanged lines in 9 files lost coverage.
Overall coverage decreased (-0.7%) to 87.963%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
builtin/linked_hash_map.mbt	0	2	0.0%
devec/devec.mbt	0	2	0.0%

Files with Coverage Reduction	New Missed Lines	%
hashmap/hashmap.mbt	2	95.65%
devec/devec.mbt	2	87.5%
immut/sorted_set/immutable_set.mbt	3	91.04%
queue/queue.mbt	3	88.71%
immut/hashmap/HAMT.mbt	3	71.43%
immut/list/list.mbt	3	93.56%
immut/hashset/HAMT.mbt	3	73.85%
immut/priority_queue/priority_queue.mbt	4	84.09%
priority_queue/priority_queue.mbt	4	80.0%

Totals
Change from base Build 1927:	-0.7%
Covered Lines:	3135
Relevant Lines:	3564

💛 - Coveralls

Yoorkin · 2024-06-26T06:37:49Z

hashmap/hashmap.mbti

@@ -1,6 +1,7 @@
 package moonbitlang/core/hashmap

 // Values
+fn of[K : Eq + Hash, V](FixedArray[Tuple[K, V]]) -> HashMap[K, V]


This of function is not a method of HashMap

Yoorkin · 2024-06-26T06:39:42Z

immut/array/array.mbti

@@ -9,6 +9,8 @@ fn is_empty[T](ImmutableVec[T]) -> Bool

 fn length[T](ImmutableVec[T]) -> Int

+fn of[T](FixedArray[T]) -> ImmutableVec[T]


Same as above

Yoorkin · 2024-06-26T06:40:04Z

immut/list/list.mbti

@@ -1,6 +1,8 @@
 package moonbitlang/core/immut/list

 // Values
+fn of[T](FixedArray[T]) -> List[T]


Yoorkin · 2024-06-26T06:46:45Z

immut/array/array.mbt

@@ -76,8 +76,8 @@ pub fn as_iter[T](self : ImmutableVec[T]) -> Iter[T] {
 }

 test "as_iter" {
-  let buf = Buffer::new(size_hint=20)
-  let v = ImmutableVec::[1, 2, 3]
+  let buf = Buffer::make(20)


please don't use deprecated Buffer::make, it will be removed soon.

Yoorkin · 2024-06-26T06:52:30Z

priority_queue/priority_queue_test.mbt

  inspect(v.to_array().to_string(), content="[4, 3, 2, 1]")?
  inspect(v.to_array().to_string(), content="[4, 3, 2, 1]")?
 }

 test "as_iter" {
-  let buf = Buffer::new(size_hint=20)
-  let v = PriorityQueue::[1, 2, 3]
+  let buf = Buffer::make(20)


Buffer::new(size_hint=20)

qazxcdswe123 requested a review from Yoorkin June 25, 2024 10:01

qazxcdswe123 marked this pull request as draft June 25, 2024 10:18

qazxcdswe123 added 15 commits June 25, 2024 18:22

refactor: update Bytes::of parameter type to FixedArray[Int]

1de9da8

hashmap

a8716b9

hashset

dd50272

devec

e0762b5

immut array

c2df2c5

HAMT

75ee36f

hashset

05e0676

list

1cd499c

immut/pq

96cdfd0

pq

065f4bf

sorted map

73ed46b

immut/sorted_set

898c3d6

queue

c25c2dc

sorted_set

3898ea7

moon info

ed0bfc9

qazxcdswe123 force-pushed the replace-with-of branch from 5fd68cd to ed0bfc9 Compare June 25, 2024 10:23

qazxcdswe123 marked this pull request as ready for review June 25, 2024 10:23

qazxcdswe123 marked this pull request as draft June 25, 2024 10:26

qazxcdswe123 removed the request for review from Yoorkin June 25, 2024 10:26

fix: update failed test

12feaf6

qazxcdswe123 changed the title ~~Replace with of~~ Replace T::[_] with T::of Jun 25, 2024

qazxcdswe123 added 5 commits June 26, 2024 10:46

linkedhashmap

6d1e1b7

pq

b2afda3

ci: info + fmt

71cb72a

Merge branch 'main' into replace-with-of

2d28b80

update to_string and test

58e684c

qazxcdswe123 force-pushed the replace-with-of branch from cdec636 to 58e684c Compare June 26, 2024 03:08

qazxcdswe123 requested a review from Yoorkin June 26, 2024 03:11

qazxcdswe123 marked this pull request as ready for review June 26, 2024 03:11

Yoorkin reviewed Jun 26, 2024

View reviewed changes

qazxcdswe123 marked this pull request as draft June 26, 2024 06:57

qazxcdswe123 closed this Jun 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace T::[_] with T::of #606

Replace T::[_] with T::of #606

qazxcdswe123 commented Jun 25, 2024

coderabbitai bot commented Jun 25, 2024

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

coveralls commented Jun 26, 2024 •

edited

Loading

coveralls commented Jun 26, 2024 •

edited

Loading

Yoorkin Jun 26, 2024

Yoorkin Jun 26, 2024

Yoorkin Jun 26, 2024

Yoorkin Jun 26, 2024 •

edited

Loading

Yoorkin Jun 26, 2024

		@@ -9,6 +9,8 @@ fn is_empty[T](ImmutableVec[T]) -> Bool

		fn length[T](ImmutableVec[T]) -> Int

		fn of[T](FixedArray[T]) -> ImmutableVec[T]

Replace T::[_] with T::of #606

Replace T::[_] with T::of #606

Conversation

qazxcdswe123 commented Jun 25, 2024

coderabbitai bot commented Jun 25, 2024

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

coveralls commented Jun 26, 2024 • edited Loading

Pull Request Test Coverage Report for Build 1931

Details

💛 - Coveralls

coveralls commented Jun 26, 2024 • edited Loading

Pull Request Test Coverage Report for Build 1930

Details

💛 - Coveralls

Yoorkin Jun 26, 2024

Choose a reason for hiding this comment

Yoorkin Jun 26, 2024

Choose a reason for hiding this comment

Yoorkin Jun 26, 2024

Choose a reason for hiding this comment

Yoorkin Jun 26, 2024 • edited Loading

Choose a reason for hiding this comment

Yoorkin Jun 26, 2024

Choose a reason for hiding this comment

CodeRabbit Configration File (`.coderabbit.yaml`)

coveralls commented Jun 26, 2024 •

edited

Loading

coveralls commented Jun 26, 2024 •

edited

Loading

Yoorkin Jun 26, 2024 •

edited

Loading