Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more function to deque #77

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Conversation

Lampese
Copy link
Collaborator

@Lampese Lampese commented Mar 18, 2024

As we mentioned in #69, this PR adds the pop function, which does not require a return value, and two utility functions.

Copy link
Contributor

@bobzhang bobzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo some comments

deque/deque.mbt Show resolved Hide resolved
deque/deque.mbt Show resolved Hide resolved
@Lampese Lampese requested a review from bobzhang March 20, 2024 14:45
@bobzhang bobzhang merged commit 84a2e99 into moonbitlang:main Mar 22, 2024
4 checks passed
@Lampese Lampese deleted the feat-deque-more branch March 22, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants