fix event and notice fetching based on selected language #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moonheart
requested changes
Jun 22, 2024
|
Hello Veirt, Thank you so much for your pull request. I truly appreciate your effort. I've added some comments for your review. Please take a look when you get a chance. Best regards, |
|
Thanks! Really appreciate you taking the time to go through the code and leave those comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made:
Modified event and notice fetching to use the selected language from the dropdown menu. Previously, it only fetched events and notices in Chinese, no matter what the selected language is.
Implemented automatic fetching of events and notices when:
a) Initially loading the website
b) Changing the language in the dropdown menu
Here's a preview video of the changes:
2024-06-22-1719071838_screenrecord.mp4
I'm making this pull request to bring attention to a bug I noticed and to propose a potential fix. As I've never used C# and Blazor before this project, I recognize there might be more efficient or idiomatic ways to achieve this.
Feel free to close this pull request if you don't find my changes suitable or if you prefer to address the issue differently.
Thank you.