This repository has been archived by the owner. It is now read-only.
Table infinite loop simpler fix #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for the patch." This reverts commit 7d5f5be. That patch might make lua tables keys mysteriously disappear in production.
…p in lua table lookups. See LuaJIT#494.
|
I believe the simpler fix broke a test in the testsuite and it was silenced in luajit2. Can you please verify that the breakage is relatively harmless? I have incorporated that test into moonjit, so a |
|
Hi, there's CI integrated into the PR workflow now, so you can simply amend your commits and set off tests to check if this change breaks anything. |
|
Confirmed that reverting the fix causes the test openresty/luajit2-test-suite@22d0cf7 to fail. |
|
OK so I went through the issue and it looks like the failing test case can be taken up as a separate issue and that the infinite loop fix could be simply fixed with this patch. I'll pull this into v2.1 as well. Thanks @lblasc ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenResty luajit fork reverted 7d5f5be, see: LuaJIT#494 (comment). I think it is beneficial do to the same in moonjit until this is resolved correctly.
Thank you for taking maintainership of LuaJIT in this new fork. Keep up the good work!