This repository has been archived by the owner. It is now read-only.
Prevent crash during ffi.load() when dlerror() returns NULL #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the standard definition of dlerror, this should never happen, but we have observed it occurring on certain versions of Android anyway.
|
Thanks, can you please add the comment too? It is useful and will prevent people from accidentally removing the check in future. |
where a crash was recognized for what workaround was developed
|
Here's the commit adding the message from the Wohlsoft fork— does this work? |
|
Perfect, I've added this to master as well now. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the standard definition of dlerror, it should never return NULL, but we (lovr.org) have observed dlerror returning NULL anyway on certain versions of Android (Android 7.1.1 on Oculus Quest when loading a nonexistent .so). Current LuaJIT implementation crashes at this point and MoonJIT is affected. The patch issues a well-formed error instead of crashing.
This patch is currently in the WohlSoft LuaJIT fork with a more extensive comment WohlSoft#13 and is in the queue in LuaJIT. LuaJIT#522