Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plan to add hdr support? #858

Open
benzhe opened this issue Oct 30, 2022 · 5 comments
Open

Any plan to add hdr support? #858

benzhe opened this issue Oct 30, 2022 · 5 comments

Comments

@benzhe
Copy link

benzhe commented Oct 30, 2022

Please provide the following info.

NVidia Geforce Experience version:
Moonlight Embedded version:
Moonlight Embedded source: repository/included in distribution/compiled from source/...
Moonlight Embedded running on: Raspberry Pi/Cubox-i/Hummingboard/Other linux device/...
Moonlight Embedded running on distribution: Arch Linux/Raspbian/OpenELEC/...

Verbose output -verbose of Moonlight Embedded:

What is the expected result?

What happens instead of that?

@cgutman
Copy link
Member

cgutman commented Oct 31, 2022

The core code for HDR should be pretty trivial. The challenge is supporting the various video backends and testing on HDR-capable hardware.

What platform are you looking for HDR support for?

@benzhe
Copy link
Author

benzhe commented Nov 8, 2022

Sorry for the late response. I am using a moonlight-embedded build named Luna for CoreELEC, which is based on Kodi for Amlogic hardware. Amlogic devices have a high market share in the TV media box, and it seems most TV released these years have HDR features.

https://github.com/TheChoconut/Luna

@cgutman
Copy link
Member

cgutman commented Nov 9, 2022

I introduced the basic HDR plumbing with c2f21b9 which enables HDR with the -hdr option.

On the Amlogic side, it looks like amcodec does most of the heavy lifting for HDR. I was able to successfully enter HDR mode on a Vero 4K with the latest code in master.

Which Amlogic device are you using?

@benzhe
Copy link
Author

benzhe commented Nov 9, 2022

I introduced the basic HDR plumbing with c2f21b9 which enables HDR with the -hdr option.

On the Amlogic side, it looks like amcodec does most of the heavy lifting for HDR. I was able to successfully enter HDR mode on a Vero 4K with the latest code in master.

Which Amlogic device are you using?

That's cool! I will try it later. And my device is TX3, with S905x3 SOC.

@benzhe
Copy link
Author

benzhe commented Nov 12, 2022

Hi @TheChoconut , can you merge this commit into your fork? This request may seem weird since I found my compilation buggy on CoreELEC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants