Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Produce error messages from common-c that aren't useless #100

Closed
cgutman opened this issue May 3, 2015 · 4 comments
Closed
Milestone

Comments

@cgutman
Copy link
Member

cgutman commented May 3, 2015

Many (all?) of the error messages generated when common-c fails to connect for some reason display an error code of -1 which is useless for diagnosing anything. We should at least display the real socket error code or (preferably) text like "Connection Refused" or "Connection Timed Out". This is probably a task that will involve both common-c and iOS-specific code.

It will help diagnosed problems like #98

@cgutman cgutman added this to the 1.0 milestone May 3, 2015
@ghost
Copy link

ghost commented May 3, 2015

please can you remove me from the beta.

Many thanks.

On 3 May 2015 at 18:45, Cameron Gutman notifications@github.com wrote:

Many (all?) of the error messages generated when common-c fails to connect
for some reason display an error code of -1 which is useless for diagnosing
anything. We should at least display the real socket error code or
(preferably) text like "Connection Refused" or "Connection Timed Out". This
is probably a task that will involve both common-c and iOS-specific code.

It will help diagnosed problems like #98
#98


Reply to this email directly or view it on GitHub
#100.

@mrb113
Copy link
Member

mrb113 commented May 4, 2015

@cgutman I took a short look at RTSP and performRtspHandshake() returns only -1 on failure. Since I own(ed) most of RTSP, I dibs looking at that method in common-c and returning some more useful exit codes for each of the failures.

@dwaxemberg
Copy link
Member

@cgutman @mrb113 any updates on this? Just going through the issues marked for v1 and getting them checked off.

@cgutman
Copy link
Member Author

cgutman commented Jul 10, 2015

This is fixed in common.

@cgutman cgutman closed this as completed Jul 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants