-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Entries for JDK 8 and 11 #38
Comments
So a new feature entry is being added - Java Development. Currently this adds into this ordering, we can change this though: Addition of the newer JDK 8 entry now looks like this, when the existing entry now pointed to download JDK 11: Version number also added #39 . The only problem that currently I'm seeing is download-ability. Currently, the mechanism to determine if Java installed (and adding a downloaded tick) works in following ways:
Since I have Thoughts are welcome. |
Currently, we don't have a version check mechanism for Java, and neither for any other SDK other than Flex. This may create problem when:
|
Moonshine SDK Installer will need to check the Java version at least. If there are Java directories in MoonshineSDKs, iterate through them and:
Then, check JAVA_HOME
If OpenJDK or OpenJDK 8 does not have a matching JDK assigned, then they should be conidered uninstalled. |
…st env-variable version check (#38)
- Have multiple JDK path settings - Update JDK paths based on InstallerSharedCore detections (Moonshine-IDE/Moonshine-SDK-Installer#38)
Some updates until now:
This still in a starting stage of the development, problems may found, and needs more tests. |
I did a quick test with the standard use case on macOS, and the Moonshine SDK Installer use cases look good. The Installer logic also worked. Here is a test matrix based on the logic we discussed above. Let me know if there are any missing cases, or if some cases are not possible to test:
I excluded the cases where different versions of the JDK appear in MoonshineSDKs, since this shouldn't happen without manual intervention from the user. The logic was not working like I expected on the Moonshine side, but we'll discuss this in Moonshine-IDE/Moonshine-IDE#755 |
I have updated the above test-matrix with more entries I could think about, with some fixes. However, I couldn't able to get a full tests on macOS since download problem of OpenJDK versions. While I tried to download v11 or v15 from https://adoptopenjdk.net/releases.html site, resulting tar.gz file always extracts a single file instead of a directory in my tests. I see the resulting file has 'bin' folder inside it, if I right-click on the file and chose "Show Package Content". But extract-out those files on a directory and if try running on Terminal (i.e. For now, I leave the macOS tests at my side. |
…e getting-started listing (#38)
…e getting-started listing (Moonshine-IDE/Moonshine-SDK-Installer#38) (#755)
I noticed that the "Required for" list for OpenJDK 8 is: Java Development, Domino Support I'd like to keep OpenJDK as the only requirement for Java Development, so that the user doesn't feel like they need to install both if they don't specifically need JDK 8. |
In my macOS tests, I see that OpenJDK 8 now installs with this path:
This causes the OpenJDK 8 check to fail, since it expects this path
The OpenJDK (11) install matches the second pattern above. |
…ture - Minor textual changes in description (#38)
I have fixed the problem where JDK 11 was unzipping properly but JDK 8 - and the resulting JDK 8 directory left an .app file like structure. Here is some notes on the fix, I see I did some weird handling for the JDK particularly where it involves looking into
I have removed JDK8 'Java Development' criteria. |
I think this logic is working well. It should be fine to merge this, as long as it is not a problem if the Moonshine-IDE/Moonshine-IDE#755 changes are not merged yet - that issue needs more work. |
I'm not sure why we have miss that during our review. This seems to be ready. Can we close it ? |
Yeah, the MSDKI side of this seems fine, though there are some remaining issues on the Moonshine side (Moonshine-IDE/Moonshine-IDE#755). |
We want to start using JDK 11 as the default JDK for Moonshine to better support the language server. However, we have some features and pending features that use the HCL Domino API, which requires JDK 8.
To support this, we want to have two entries for Java in Moonshine SDK Installer:
I was surprised that the The "Java Development" feature is new - it seemed odd that this was not added before. Here is a description:
We will need to store the two SDKs separately in Moonshine. We can discuss the options for this in a Moonshine issue.
The text was updated successfully, but these errors were encountered: