Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually requested downloads at same time do not queue #40

Closed
rat-moonshine opened this issue Mar 12, 2021 · 4 comments
Closed

Manually requested downloads at same time do not queue #40

rat-moonshine opened this issue Mar 12, 2021 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@rat-moonshine
Copy link
Collaborator

While testing multiple JDK download requests (v11, v8) at a same time, the interface didn't shown the downloads are in queued manner and have started parallelly causing UI notification conflicts (causing by different download events) and some internal problems as well.

We need to fix that the downloads always runs in a queued manner.

@rat-moonshine rat-moonshine added the bug Something isn't working label Mar 12, 2021
@rat-moonshine rat-moonshine self-assigned this Mar 12, 2021
@rat-moonshine rat-moonshine added this to the v3.7.0 milestone Mar 12, 2021
@rat-moonshine rat-moonshine changed the title Manually requested multiple downloads at same time do not queue Manually requested downloads at same time do not queue Mar 12, 2021
rat-moonshine added a commit that referenced this issue Mar 12, 2021
@rat-moonshine
Copy link
Collaborator Author

@JoelProminic this is now ready for a test. Please, check.

@JoelProminic
Copy link
Contributor

I tested with the branch build, and queuing is working properly now. I tested on both macOS and Windows. This should be ready for a merge.

@piotrzarzycki21
Copy link
Collaborator

I have removed tag. When it will be possible merge it.

@JoelProminic
Copy link
Contributor

These changes were made in master. This is working for the original test cases, but I noticed some potential problems for #32. I'll reopen this issue if I confirm that there is a remaining problem.

@piotrzarzycki21 piotrzarzycki21 modified the milestones: v3.7.0, v3.8.0 May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

3 participants