Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Harman Air to Installer #32

Closed
piotrzarzycki21 opened this issue Dec 8, 2020 · 76 comments
Closed

Add Harman Air to Installer #32

piotrzarzycki21 opened this issue Dec 8, 2020 · 76 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@piotrzarzycki21
Copy link
Collaborator

We should investigate what we need to do in order to add Harman Air to our installer.

Current path to install Harman Air for Flex developer is following:

  1. You need to download Air SDK for Flex Developers
  2. Unpack it and follow instructions Overlay AIR SDK on Flex SDK

Options:

  1. User has Flex + old Adobe Air on disk
    Because it would be a lot of downloading if we first download Flex + Adobe Air and next overlay with Harman Air, maybe user should be forced to point folder with Flex which he have to have on disk.

  2. User has only Flex binaries - no Adobe Air SDK
    The other options is to download pure binaries Apache Flex binaries without any dependencies and overlay it with Harman Air - I'm not sure if it would work.

@piotrzarzycki21 piotrzarzycki21 added the enhancement New feature or request label Dec 8, 2020
@rat-moonshine
Copy link
Collaborator

rat-moonshine commented Dec 10, 2020

By the current MSDKI way, the application has fixed versions for each particular SDK which determines from its configuration file. This also decides which version of Flex and AIR SDK should download.

Remaining by the existing way, I can imagine a new entry of Flex SDK with Harman AIR, which shall download a Flex SDK and Harman AIR SDK and uncompress them in a way so the AIR overlays correctly on Flex SDK. I guess the build.xml in Flex SDK also downloads AIR SDK, we need to see if we can prevent it from doing that.

For any existing Flex SDK (with or without AIR), user can go following the instruction of overlaying Harman AIR and do this by themselves only. I'm not in a favor of cover many test cases with different way of doing on this regard.

@piotrzarzycki21
Copy link
Collaborator Author

Maybe we should go with simpler way. Just add entry which downloads Harman Air for Flex Developers and put message for the user - that he has to download manually Flex SDK binaries and unpack it to folder with downloaded Harman Air.

However I need to first check if Flex SDK binaries + Harman Air is enough to work.

@rat-moonshine
Copy link
Collaborator

Maybe we should go with simpler way. Just add entry which downloads Harman Air for Flex Developers and put message for the user - that he has to download manually Flex SDK binaries and unpack it to folder with downloaded Harman Air.

This could be a simpler procedure for us, however, this may not support the idea behind creating MSDKI - to install fully working SDK to the user's system.

On a separate note, we may need to ensure that we won't get into any legal trouble if we distribute Harman AIR through MSDKI (if the MSDKI nature is meant to be a distribution) if we already not did.

@piotrzarzycki21
Copy link
Collaborator Author

Maybe we should go with simpler way. Just add entry which downloads Harman Air for Flex Developers and put message for the user - that he has to download manually Flex SDK binaries and unpack it to folder with downloaded Harman Air.

This could be a simpler procedure for us, however, this may not support the idea behind creating MSDKI - to install fully working SDK to the user's system.

On a separate note, we may need to ensure that we won't get into any legal trouble if we distribute Harman AIR through MSDKI (if the MSDKI nature is meant to be a distribution) if we already not did.

Before we place link in our MSDKI I will ask them.

@JoelProminic
Copy link
Contributor

JoelProminic commented Feb 3, 2021

We had some more discussion for this here: Moonshine-IDE/Moonshine-IDE#773

The plan is to download and extract a fresh copy of the Flex SDK.

Then Harman AIR should be downloaded and extracted into new SDK directory.

Then we will need to use an Ant script to update some references in frameworks/air-config.xml. Remove {airHome}/frameworks/ in these lines:

      <external-library-path>
          <path-element>{airHome}/frameworks/libs/air/airglobal.swc</path-element>
      </external-library-path>
...
      <library-path>
         <path-element>libs</path-element>
         <path-element>libs/mx</path-element>
         <path-element>libs/air</path-element>
         <path-element>{airHome}/frameworks/libs/air</path-element>

Note that the second reference can be removed entirely, since we already have a path-element for libs/air.

We may also need to update some other configuration files similar to what the Flex SDK Installer script is doing currently. For example update the AIR version in flex-sdk-description.xml.

@rat-moonshine
Copy link
Collaborator

I'm starts looking into this.

@rat-moonshine rat-moonshine self-assigned this Feb 8, 2021
@rat-moonshine rat-moonshine modified the milestones: v3.7.1, v3.7.0 Feb 8, 2021
rat-moonshine added a commit that referenced this issue Feb 10, 2021
- Initial detections for the Flex/Harman
- Changes in Moonshine source on initial detections
- Copyright load/show changes for the Flex/Harman
(#32)
@rat-moonshine
Copy link
Collaborator

rat-moonshine commented Feb 10, 2021

Updates:

  • Addition of new Flex/Harman entry
  • Initial detection for the Flex/Harman at Moonshine SDK Installer side
  • Changes in Moonshine source on initial detection at Moonshine side
  • Copyright load/show changes for the Flex/Harman

(The multi-copyright information for Flex/Harman currently loads from https://moonshine-ide.com/downloads/msdki/apache-flex-harman-sdk-installer-config.xml, when in case of Flex/Adobe loads from their remote site - http://www.apache.org/dist/flex/4.16.1/binaries/apache-flex-sdk-installer-config.xml. Having the Flex/Harman hosted remotely also fits the current design of parsing and triggering copyright URLs, in MSDKI. The other way could be having the xml bundled in the package, but this will cost additional logic in MSDKI to understand a local source).

@JoelProminic
Copy link
Contributor

I see @rat-moonshine got the license for Harman AIR from this page: https://airsdk.harman.com/download

We'll need to be careful that we are displaying this properly for users. I'm not sure if we need to show the privacy policy and other links as well.

@rat-moonshine
Copy link
Collaborator

rat-moonshine commented Feb 15, 2021

While working on the downloading scripts in Ant file for the Harman AIR SDK, it starts to terminates every time.

After some investigation it found that accepting the copyright information (at Haman website) generates an id-based download URL, i.e.
https://airsdk.harman.com/api/versions/33.1.1.345/sdks/AIRSDK_Flex_Windows.zip?id=63270

If one try to access the above link, s/he could see something like this:

Invalid link to the AIR SDK

The SDK can only be downloaded from the website, after acknowledging the Terms and Conditions under which it is to be used.
Please do not share direct links to the SDK files.

If you are seeing this message, please visit https://airsdk.harman.com/download and try again.

While trying to download through Ant by not generating a valid download-id, download starts failing each time. It appears the id is browser-session-based.

The possible solution could be (either any):

  1. Ask Harman for the API access to get an id (if the API strictly rely on browser-session then it might not work in desktop run)
  2. Ask Harman for providing a direct link access

@piotrzarzycki21
Copy link
Collaborator Author

@rat-moonshine So do we have a way of moving forward with that ?

@rat-moonshine
Copy link
Collaborator

I didn't have a chance so far I shall plan to re-visit that shortly.

@rat-moonshine
Copy link
Collaborator

Okay. Some updates here, if this interests you. I spent some time testing with the link supplied by Andrew using the small utility Ant build script that downloads, extracts and updates the air-config file.

Tested on macOS currently, the results seems to be successful:
image

I confirm the folder populated with all the files and the air-config also being updated:
image

A test still pending on Windows. I have added the Ant build file in the repository.

rat-moonshine added a commit that referenced this issue Apr 29, 2021
rat-moonshine added a commit that referenced this issue Apr 30, 2021
…arman_sdk

# Resolved Conflicts:
#	InstallerSharedCore/src/actionScripts/interfaces/IHelperMoonshineBridge.as
#	InstallerSharedCore/src/actionScripts/managers/DetectionManager.as
#	InstallerSharedCore/src/actionScripts/utils/HelperUtils.as
#	InstallerSharedCore/src/actionScripts/valueObjects/ComponentTypes.as
#	InstallerSharedCore/src/components/renderers/ComponentRenderer.mxml
#	InstallerSharedCore/src/helperResources/data/moonshineHelperConfig.xml

(#32)
@rat-moonshine
Copy link
Collaborator

rat-moonshine commented Apr 30, 2021

I have committed first working version of Apache Flex + Harman AIR download/extract/merge process, currently testing only on macOS. There still some UI tuning requires but the download and merge process is mostly working.

However, I'm seeing strange problem while trying to run Flex Desktop sample project:

: Command: "/Users/devsena/Downloads/MoonshineSDKss/Flex_SDK/Flex4161AIR331/apache-flex-sdk-4.16.1-bin/bin/mxmlc" -load-config+=obj/NewFlexDesktopProjectConfig.xml -optimize=false +configname=air -debug=true
: SDK path: /Users/devsena/Downloads/MoonshineSDKss/Flex_SDK/Flex4161AIR331/apache-flex-sdk-4.16.1-bin
: Sending to mxmlc: "/Users/devsena/Downloads/MoonshineSDKss/Flex_SDK/Flex4161AIR331/apache-flex-sdk-4.16.1-bin/bin/mxmlc" -load-config+=obj/NewFlexDesktopProjectConfig.xml -optimize=false +configname=air -debug=true
: Using AIR SDK: /Users/devsena/Downloads/MoonshineSDKss/Flex_SDK/Flex4161AIR331/apache-flex-sdk-4.16.1-bin
: Using AIR SDK: /Users/devsena/Downloads/MoonshineSDKss/Flex_SDK/Flex4161AIR331/apache-flex-sdk-4.16.1-bin
: Loading configuration: /Users/devsena/Downloads/MoonshineSDKss/Flex_SDK/Flex4161AIR331/apache-flex-sdk-4.16.1-bin/frameworks/air-config.xml
: Loading configuration: /Users/devsena/Desktop/NewFlexDesktopProject/obj/NewFlexDesktopProjectConfig.xml
: Loading configuration: /Users/devsena/Downloads/MoonshineSDKss/Flex_SDK/Flex4161AIR331/apache-flex-sdk-4.16.1-bin/frameworks/air-config.xml
: Loading configuration: /Users/devsena/Desktop/NewFlexDesktopProject/obj/NewFlexDesktopProjectConfig.xml
: Error: /Users/devsena/Desktop/NewFlexDesktopProject/src/NewFlexDesktopProject.mxml is of an unsupported type: mxml
: Error: /Users/devsena/Desktop/NewFlexDesktopProject/src/NewFlexDesktopProject.mxml is of an unsupported type: mxml

I tried to test by manually downloading Apache Flex binary and Harman AIR SDK and merge the latter over former, that also result the above error.

One can download a Flex binary from here (macOS): https://apachemirror.wuchna.com/flex/4.16.1/binaries/apache-flex-sdk-4.16.1-bin.tar.gz. Untar it somewhere.
Download the Harman AIR SDK: https://airsdk.harman.com/api/versions/33.1.1.406/sdks/AIRSDK_MacOS.zip (add requisite suffix as suggested by Andrew in his last email) and try to untar the AIR on Flex directory.

I confirm the air-config.xml file has necessary changes by itself, but I'm not familiar with this new error.

(Untar command if it's handy: tar -xvf $targetFileName)

@rat-moonshine
Copy link
Collaborator

During a manual download/test by @JoelProminic the merged SDK seems to worked for him. The difference he chose is to run unzip command instead of tar against AIRSDK_MacOS.zip - when the unzip command was failing for me some reason during Ant script run.

I shall re-visit these command and tests again.

@JoelProminic
Copy link
Contributor

For quick reference, here are my commands. tar should work with .zip files, but maybe you had the wrong options

$ ls -1
AIRSDK_MacOS.zip
apache-flex-sdk-4.16.1-bin.tar.gz
$ tar xzvf apache-flex-sdk-4.16.1-bin.tar.gz
$ cd apache-flex-sdk-4.16.1-bin
$ unzip -o ../AIRSDK_MacOS.zip 

@rat-moonshine
Copy link
Collaborator

rat-moonshine commented May 3, 2021

In practice, this didn't helped me either. I continue to see the error along with a new different warning, on macOS:

: Compiling NewFlexDesktopProject
: Command: "/Users/devsena/Downloads/MoonshineSDKss/Flex_SDK/apache-flex-sdk-4.16.1-bin/bin/mxmlc" -load-config+=obj/NewFlexDesktopProjectConfig.xml -optimize=false +configname=air -debug=true
: SDK path: /Users/devsena/Downloads/MoonshineSDKss/Flex_SDK/apache-flex-sdk-4.16.1-bin
: Sending to mxmlc: "/Users/devsena/Downloads/MoonshineSDKss/Flex_SDK/apache-flex-sdk-4.16.1-bin/bin/mxmlc" -load-config+=obj/NewFlexDesktopProjectConfig.xml -optimize=false +configname=air -debug=true
: Using AIR SDK: /Users/devsena/Downloads/MoonshineSDKss/Flex_SDK/apache-flex-sdk-4.16.1-bin
: WARNING: An illegal reflective access operation has occurred
: WARNING: Illegal reflective access by com.google.common.base.internal.Finalizer (file:/Users/devsena/Downloads/MoonshineSDKss/Flex_SDK/apache-flex-sdk-4.16.1-bin/lib/guava-r08.jar) to field java.lang.Thread.inheritableThreadLocals
: WARNING: Please consider reporting this to the maintainers of com.google.common.base.internal.Finalizer
: WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
: WARNING: All illegal access operations will be denied in a future release
: Loading configuration: /Users/devsena/Downloads/MoonshineSDKss/Flex_SDK/apache-flex-sdk-4.16.1-bin/frameworks/air-config.xml
: Loading configuration: /Users/devsena/Desktop/NewFlexDesktopProject/obj/NewFlexDesktopProjectConfig.xml
: Error: /Users/devsena/Desktop/NewFlexDesktopProject/src/NewFlexDesktopProject.mxml is of an unsupported type: mxml

I even tried to remove any extended attributes if causing the warnings, but that didn't helped too.

However, building a pure ActionScript project (.as) seems to be successful (with warning):

: Compiling NewActionScriptDesktopProject
: Command: "/Users/devsena/Downloads/MoonshineSDKss/Flex_SDK/apache-flex-sdk-4.16.1-bin/bin/mxmlc" -load-config+=obj/NewActionScriptDesktopProjectConfig.xml -optimize=false +configname=air -debug=true
: SDK path: /Users/devsena/Downloads/MoonshineSDKss/Flex_SDK/apache-flex-sdk-4.16.1-bin
: Sending to mxmlc: "/Users/devsena/Downloads/MoonshineSDKss/Flex_SDK/apache-flex-sdk-4.16.1-bin/bin/mxmlc" -load-config+=obj/NewActionScriptDesktopProjectConfig.xml -optimize=false +configname=air -debug=true
: Using AIR SDK: /Users/devsena/Downloads/MoonshineSDKss/Flex_SDK/apache-flex-sdk-4.16.1-bin
: WARNING: An illegal reflective access operation has occurred
: WARNING: Illegal reflective access by com.google.common.base.internal.Finalizer (file:/Users/devsena/Downloads/MoonshineSDKss/Flex_SDK/apache-flex-sdk-4.16.1-bin/lib/guava-r08.jar) to field java.lang.Thread.inheritableThreadLocals
: WARNING: Please consider reporting this to the maintainers of com.google.common.base.internal.Finalizer
: WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
: WARNING: All illegal access operations will be denied in a future release
: Loading configuration: /Users/devsena/Downloads/MoonshineSDKss/Flex_SDK/apache-flex-sdk-4.16.1-bin/frameworks/air-config.xml
: Loading configuration: /Users/devsena/Desktop/NewActionScriptDesktopProject/obj/NewActionScriptDesktopProjectConfig.xml
: 914 bytes written to /Users/devsena/Desktop/NewActionScriptDesktopProject/bin-debug/NewActionScriptDesktopProject.swf in 2.613 seconds
: Build completed successfully.
: Launching application: NewActionScriptDesktopProject

@rat-moonshine
Copy link
Collaborator

Updates now merged onto master.

@piotrzarzycki21
Copy link
Collaborator Author

I have downloaded newest nightly and I see there Build 260, but in JSON on the server build is being marked as 261, so I'm not sure what I'm using actually. I did install that couple of times.

Screenshot 2021-07-16 at 12 54 27

@rat-moonshine
Copy link
Collaborator

I have fixed the symlink issues in installing SDK. SDK is now installed properly on Bamboo build system. I need to writeup a detail documentation on this soon.

@piotrzarzycki21
Copy link
Collaborator Author

Great! I have successfully installed Harman Air with new nightly. One issue left to close this one I believe.

@rat-moonshine
Copy link
Collaborator

We were facing an (application)startup error on macOS packaged with the Harman SDK/Flex for some time:

This application requires a version of Adobe AIR which cannot be found.
image

After investigation it turned out the problem is not related with overlaying-ways of Harman SDK on Apache Flex, but unzipping-ways of Harman SDK.

There are some symlink files exists in the Adobe AIR.framework directory of Harman AIR - while unzipping the SDK(.zip) directly on Terminal, the symlink files preserves their actual nature after being expanded. While unzipping through Ant it produce different results:

Type of unzip Code After SDK expanded
unzip <unzip src="${air.tar.name}" dest="${download.dir}/airsdk" overwrite="true" /> All symlink files expanded as text file, even executables are expanded as non-executable on macOS; Recommend not to use unzip on macOS
tar <exec executable="tar" dir="${download.dir}/airsdk"><arg value="-xf" /><arg value="${air.tar.name}" /></exec> All symlink files expanded as executable, clicking on the executable does nothing

In any way, tar seems to be more to unzip on macOS.

The broken symlink files in Adobe AIR.framework continued to create startup error for the application those packaged using the SDK.

After some discussion @JoelProminic pointed this might be a known issue to Ant. We also decided to manually delete the broken symlink files and re-create them.

@JoelProminic suggested with some good ways to get a list of symlink files (to a directory) and an working way to re-create the list of symlink files in Ant:

Get a list of symlink files to test_valid directory

$ find test_valid -type l -ls | sed 's:^[^/]*/::'
runtimes/air-captive/mac/Adobe AIR.framework/Adobe AIR -> Versions/Current/Adobe AIR
runtimes/air-captive/mac/Adobe AIR.framework/Versions/1.0/Adobe AIR_64 -> Adobe AIR
runtimes/air-captive/mac/Adobe AIR.framework/Versions/Current -> 1.0
runtimes/air-captive/mac/Adobe AIR.framework/Resources -> Versions/Current/Resources
runtimes/air/mac/Adobe AIR.framework/Adobe AIR -> Versions/Current/Adobe AIR
runtimes/air/mac/Adobe AIR.framework/Versions/1.0/Adobe AIR_64 -> Adobe AIR
runtimes/air/mac/Adobe AIR.framework/Versions/Current -> 1.0
runtimes/air/mac/Adobe AIR.framework/Headers -> Versions/Current/Headers
runtimes/air/mac/Adobe AIR.framework/Resources -> Versions/Current/Resources

An working module to re-create list of symlink files in Ant

<target name="unzip">
        <delete dir="${unzip.dir}" />
        <unzip src="AIRSDK_Flex_MacOS.zip" dest="${unzip.dir}"/>

        <!-- Fix the symlinks -->
        <fixSymlink link="${unzip.dir}/runtimes/air-captive/mac/Adobe AIR.framework/Adobe AIR" resource="Versions/Current/Adobe AIR" />
        <fixSymlink link="${unzip.dir}/runtimes/air-captive/mac/Adobe AIR.framework/Resources" resource="Versions/Current/Resources" />
        <fixSymlink link="${unzip.dir}/runtimes/air-captive/mac/Adobe AIR.framework/Versions/1.0/Adobe AIR_64" resource="Adobe AIR" />
        <fixSymlink link="${unzip.dir}/runtimes/air-captive/mac/Adobe AIR.framework/Versions/Current" resource="1.0" />
        <fixSymlink link="${unzip.dir}/runtimes/air/mac/Adobe AIR.framework/Adobe AIR" resource="Versions/Current/Adobe AIR" />
        <fixSymlink link="${unzip.dir}/runtimes/air/mac/Adobe AIR.framework/Headers" resource="Versions/Current/Headers" />
        <fixSymlink link="${unzip.dir}/runtimes/air/mac/Adobe AIR.framework/Resources" resource="Versions/Current/Resources" />
        <fixSymlink link="${unzip.dir}/runtimes/air/mac/Adobe AIR.framework/Versions/1.0/Adobe AIR_64" resource="Adobe AIR" />
        <fixSymlink link="${unzip.dir}/runtimes/air/mac/Adobe AIR.framework/Versions/Current" resource="1.0" />
</target>

<macrodef name="fixSymlink" description="Fix a symlink from the unzip command">
        <attribute name="link" />
        <attribute name="resource" />
        <sequential>
            <delete file="@{link}" />
            <symlink link="@{link}" resource="@{resource}"/>
        </sequential>
</macrodef>

While the Ant solution should be pretty good for direct-Ant handling, @piotrzarzycki21 this might worthy for you in case of Git Actions Ant run. Unfortunately, this didn't worked-out using original SDK Installer source.

MSDKI, or the original SDK Installer source uses an ActionScript implementation of real Ant API. This is to facilitate Ant running in the system where Ant SDK is not installed (if I'm right). The ActionScript implementation is pretty old, and supports only very basic tags from Ant SDK, here's a complete list of the tags - https://github.com/Moonshine-IDE/Moonshine-SDK-Installer/tree/master/flex-utilities/flex-installer/ant_on_air/src/org/apache/flex/ant/tags.

The implementation thrown error while executing tags like macrodef, sequential or symlink. I could anyway alternate the process to use target instead of macrodef with some attributes, but symlink anyway is not available in the using API. We always requires to work with very limited amount of tags while using this API.

So I chose to go with shell-execution way. It does same thing - delete the existing/broken symlink file, re-create new symlinks.

This took me quite some time to properly execute the symlink creation process, though. This because of the relative path-way the symlink requires to be created that should work across the machines. Initially I faced troubles when a symlink created by the path of a system, failed to work on another system, i.e. symlink path fixed on Bamboo system does not work on my system. I think the working-directory also an important part in this relative path process.

Anyway, finally I able to create proper relative symlink files that works across the system. I have tested installing the SDK on Bamboo build system where symlinks get fixed as part of the MSDKI installation process, packaged application using the SDK that installed and run properly in different system.

The only thing is that the listings are fixed since running a find $path -type l doesn't list any symlink against the broken SDK. We need to manage the list ourselves based on a working SDK.

@JoelProminic
Copy link
Contributor

I did a quick test today, and the symlinks look good. I was able to Build & Run Moonshine-IDE with the latest Flex SDK (Harman AIR) install. @rat-moonshine mentioned there were a few more things to fix, and I would like to do a final Windows test before the release as well to make sure there were no unexpected changes.

@rat-moonshine
Copy link
Collaborator

@rat-moonshine mentioned there were a few more things to fix

I have completed my remaining fixes as form of:
#56
Moonshine-IDE/Moonshine-IDE#869 (comment)

I'm good to close this issue hereafter.

@piotrzarzycki21
Copy link
Collaborator Author

I have just tested downloading Harman Air and everything seems to be good! Thanks!

@JoelProminic
Copy link
Contributor

It looks like the file descriptor for the Windows Harman AIR Flex SDK was not updated. I see FP 28.0:
image

On macOS I saw Flash 27.0 and AIR 27.0 after the Apache AIR Flex SDK was installed, but this corrected itself once I restarted Moonshine.

I haven't seen any problems with Build & Run for Flex Desktop projects.

@rat-moonshine
Copy link
Collaborator

Added scripts to update SDK label text.

@piotrzarzycki21
Copy link
Collaborator Author

@Aszusz if your setup is ready please download nightly and test that on Windows. Make sure that latest build has this fix.

@piotrzarzycki21
Copy link
Collaborator Author

I have tested on Mac OSX Big Sur and I see correct value with newest build.

@Aszusz
Copy link
Collaborator

Aszusz commented Jul 22, 2021

I have tested it on Windows. I see the correct value:
image

Please note I'm seeing Harman's splash screens:

  • when I start Moonshine IDE
  • when I start SDK installer

@piotrzarzycki21
Copy link
Collaborator Author

I have tested it on Windows. I see the correct value:
image

Please note I'm seeing Harman's splash screens:

  • when I start Moonshine IDE
  • when I start SDK installer

On Mac I don't have that splash screens.

@piotrzarzycki21
Copy link
Collaborator Author

Once we fix that splash screen issues, this one should be closed and we are ready to release.

@rat-moonshine
Copy link
Collaborator

Please note I'm seeing Harman's splash screens:

when I start Moonshine IDE
when I start SDK installer

This should be fixed now with latest builds. I have placed license file recently on Windows build-system.

@Aszusz
Copy link
Collaborator

Aszusz commented Jul 22, 2021

I confirm the splash screen disappeared from both Moonshine IDE and Moonshine SDK Installer. Since everything is looking good now I'm closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

4 participants