Added a try block around ABI loading for Foundry projects #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A user reported an issue loading a Foundry project:
```
Traceback (most recent call last):
File "/Library/Frameworks/Python.framework/Versions/3.8/bin/inspector-facet", line 8, in <module>
sys.exit(main())
File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/inspector_facet/cli.py", line 161, in main
abis = foundry_project_abis(args.project, args.build_dir)
File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/inspector_facet/abi.py", line 76, in foundry_project_abis
contract_abi = contract_artifact.get("abi", [])
AttributeError: 'list' object has no attribute 'get'
```
In this PR, I wrap the `contract_artifact.get("abi", [])` call in a try block. This is an exploratory change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user reported an issue loading a Foundry project:
In this PR, I wrap the
contract_artifact.get("abi", [])call in a try block. This is an exploratory change.