Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use angular to collapse sidebar #52

Open
danpolanco opened this issue Jan 21, 2016 · 4 comments
Open

Use angular to collapse sidebar #52

danpolanco opened this issue Jan 21, 2016 · 4 comments
Assignees
@danpolanco
Labels
bug frontend medium
Milestone
0.4 - Sassy Donkey

Comments

@danpolanco
Copy link
Collaborator

The sidebar should work as seen in tui2tone's demo, but I removed the javascript that handles. I need to replace it with angular / ui magic.

screen shot 2016-01-20 at 6 36 33 pm
@danpolanco danpolanco self-assigned this Jan 21, 2016
@danpolanco danpolanco added this to the 0.1 - Gulping Toad milestone Jan 21, 2016
@itzg
Copy link
Member

itzg commented Jan 21, 2016

In this case it's probably fine to add back that specific JS.

@danpolanco
Copy link
Collaborator Author

Will do that as a temporary fix.

@itzg
Copy link
Member

itzg commented Jan 21, 2016

Yep

danpolanco added a commit that referenced this issue Jan 21, 2016
@danpolanco
Revert "Remove the last of tui2tone javascript"
210092d 
This reverts commit 1d20bd2.

A temporary fix to address #52. DanTheColoradan would like this replaced
with good angular / ui magic.
danpolanco added a commit that referenced this issue Jan 21, 2016
@danpolanco
Revert "Use UI bootstrap collapse to get close to desired collapse"
7d16535 
This reverts commit 196663f.

As addressed in #52, we are going temporarily back to using tui2tone's
javascript. DanTheColoradan would like to replace this with more angular
style ui code.
@danpolanco danpolanco added medium and removed high labels Jan 21, 2016
@danpolanco
Copy link
Collaborator Author

I forgot that adding the script back causes a weird redirect issue. Gonna try and fix that now.

@danpolanco danpolanco mentioned this issue Jan 21, 2016
Closed
@danpolanco danpolanco changed the title Sidebar doesn't extend down the page and collapse button is broken Use angular to collapse sidebar Jan 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danpolanco danpolanco

Labels
bug frontend medium
Projects
None yet
Milestone
0.4 - Sassy Donkey
Development

No branches or pull requests
2 participants
@itzg @danpolanco