Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn install issue #21

Closed
oliviertassinari opened this issue Jul 4, 2017 · 9 comments
Closed

yarn install issue #21

oliviertassinari opened this issue Jul 4, 2017 · 9 comments

Comments

@oliviertassinari
Copy link

oliviertassinari commented Jul 4, 2017

I have noticed the following behaviour trying to install wordpos with yarn.

During the first install

  • the post install script is triggered, populating wordnet-db fast index

During a consecutive, yarn thing get messy

  • yarn see that the wordnet-db folder changed and reset it to his original state. However, as wordpos is still the same, his postinstall script isn't call.
  • At that point, wordpos can't no longer be used as missing the fast index.
@oliviertassinari
Copy link
Author

oliviertassinari commented Jul 4, 2017

I use the following fix for now in the package on userspace.

package.json

  "postinstall": "cd node_modules/wordpos && yarn postinstall"`

@oliviertassinari
Copy link
Author

However, we lose ~1s for each yarn interaction, not great

@buildbreakdo
Copy link

Hmm.. ran into this too. After running your script seeing ENOENT: no such file or directory, scandir '/dict'.

@maxmatthews
Copy link

maxmatthews commented Jun 6, 2018

Any movement on this? Still having this issue and yarn only seems to be growing in popularity. The postinstall fix is a fine temp one, but is definitely a performance hit.

@moos
Copy link
Owner

moos commented Sep 2, 2018

I can't reproduce with latest yarn:

~/dev/tmp/wordpos-yarn-test$ yarn
yarn install v1.9.4
(node:81202) ExperimentalWarning: The fs.promises API is experimental
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
success Saved lockfile.
✨  Done in 5.50s.

~/dev/tmp/wordpos-yarn-test$ ls node_modules/wordnet-db/dict/
data.adj             data.verb            fast-index.noun.json index.adv            index.verb
data.adv             fast-index.adj.json  fast-index.verb.json index.noun
data.noun            fast-index.adv.json  index.adj            index.sense

Please try updating yarn.

@oliviertassinari
Copy link
Author

oliviertassinari commented Sep 2, 2018

@moos Did you run yarn twice?

@moos
Copy link
Owner

moos commented Sep 2, 2018

Yes -- I did. I was able to repro with earlier version of yarn, but not with latest.

@maxmatthews
Copy link

maxmatthews commented Sep 26, 2018

~~Can confirm that this is fixed in yarn>1.9.4. Thanks for checking this @moos

@maxmatthews
Copy link

Take it back. Just added a package and got a no such file or directory /node_modules/wordnet-db/dict/fast-index.noun.json'. Adding back the post install line got me back up and running

@moos moos closed this as completed Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants