-
Notifications
You must be signed in to change notification settings - Fork 8
Conversation
Thanks for adding tests! re:
I think that's a bad thing. It should ensure there's a space afterwards. |
Agreed, I'll look into it. |
Got it working with a positive lookahead regex, updated the channel link test to match the behavior. |
Add tests and update link regex
👍 |
Any reason you switched |
It might have been something I did wrong, but it didn't seem like |
@ekmartin ah yeah that's annoying. I think they're working on adding it in but it doesn't look like they're in a hurry. Makes sense to me to have better error output. I just like seeing the test names and checks and such when everything's fine too but until tap-spec has better error output, tap-dot is a lot more useful. |
This adds tests for most of the rich-message functionality. I used tape since it was already added to package.json, but wouldn't take much time to change it if another framework is preferred.
#8 happens because the regex mathes overlap, this should fix it. This'll however turn the
#channel
part of#channel!$#$#
into a link, but I'm not sure if that's a bad thing. If emoji channel names are to be supported it'd need an update though.