Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attributes now link to the role attribute which created them #134

Closed
wants to merge 2 commits into from
Closed

Attributes now link to the role attribute which created them #134

wants to merge 2 commits into from

Conversation

autarch
Copy link
Member

@autarch autarch commented Sep 17, 2016

No description provided.

@autarch
Copy link
Member Author

autarch commented Sep 17, 2016

Addresses https://rt.cpan.org/Ticket/Display.html?id=117586

@autarch
Copy link
Member Author

autarch commented Sep 17, 2016

Also addresses https://rt.cpan.org/Ticket/Display.html?id=84563

@autarch
Attributes now link to the role attribute which created them
4f2fbd7
@autarch
Remove old todo test for having accessors from role attribute link to…
397672c 
… role

This would be wrong, since the _accessor_ never exists in the role, just the
attribute definition.

This change addresses https://rt.cpan.org/Ticket/Display.html?id=84563 in what
I think is the most correct way.
@autarch autarch force-pushed the autarch/attribute-knows-role-attribute branch from d8be07f to 397672c Compare September 17, 2016 21:33
@karenetheridge
Copy link
Member

cool, thanks! merged.

@karenetheridge karenetheridge deleted the autarch/attribute-knows-role-attribute branch September 25, 2016 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@autarch @karenetheridge