Skip to content

Commit

Permalink
remove optional dependency (mandatory for releasers) on MXWRO when Mo…
Browse files Browse the repository at this point in the history 
…ose is new enough to have it in core
  • Loading branch information
@karenetheridge
karenetheridge committed Aug 23, 2014
1 parent b5aa873 commit dce14a7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
1 change: 0 additions & 1 deletion dist.ini
View file
Expand Up @@ -20,7 +20,6 @@ remove = MooseX::Role::WithOverloading

[Prereqs / DevelopRequires]
MooseX::AttributeHelpers = 0
MooseX::Role::WithOverloading = 0

[MetaResources]
x_IRC = irc://irc.perl.org/#moose
Expand Down
3 changes: 2 additions & 1 deletion t/40_overload.t
View file
Expand Up @@ -4,7 +4,8 @@ use strict;
use lib 't/lib';
use Test::More;

use Test::Requires 'MooseX::Role::WithOverloading';
use if !eval { require Moose; Moose->VERSION('2.1300') },
'Test::Requires' => 'MooseX::Role::WithOverloading';

use_ok 'TestOverload_Consumer', 'consumer test class loaded ok';
use_ok 'Pod::Coverage::Moose', 'pcm loaded ok';
Expand Down

5 comments on commit dce14a7

@omega
Copy link

@omega omega commented on dce14a7 Aug 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,

We have a semi-automatic system for building perl modules, and it fails to build Pod::Coverage::Moose now. We end up with Moose 2.1600, but no MooseX::Role::WithOverloading (it isn't listed in test_requires in the meta?).

if I move the eval like this:

my $res = eval { require Moose; Moose->VERSION('2.1300') };
use if !$res
    'Test::Requires' => 'MooseX::Role::WithOverloading';

the test skips properly, and installing MooseX::Role::WithOverloading manually then makes the test run and pass as well, but I do not think that is the intention of the code. (It took me a while to understand).

If I understand the commit message correctly, the idea is that MooseX::Role::WithOverloading isn't needed on Moose 2.1300 and higher? But t/lib/TestOverload.pm still has a use MooseX::Role::WithOverloading that blows up on newer Moose it seems?

(Note, I am not sure if commenting here is ok or not, please let me know if you prefer a RT issue instead)

@karenetheridge
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will look into this very soon.

@karenetheridge
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I filed this as an RT ticket: https://rt.cpan.org/Ticket/Display.html?id=106898

A fix should be up shortly.

@omega
Copy link

@omega omega commented on dce14a7 Sep 5, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karenetheridge
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and released!

Please sign in to comment.