Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(cgiserv) fix redirect_resp #443

Merged
merged 2 commits into from Jul 29, 2021
Merged

(cgiserv) fix redirect_resp #443

merged 2 commits into from Jul 29, 2021

Conversation

Eronana
Copy link
Contributor

@Eronana Eronana commented Jul 26, 2021

Motivation and Context

I got '500 Internal Server Error' caused by: net/http: HTTP/1.x transport connection broken: unexpected EOF from traefik when I use it to proxy cgiserv, and I also got error when I use nodejs to send request to http://cgiserv_ip:9425.

Description

It should ends with double CRLFs(\r\n\r\n), but there is only one CRLF.
Why? Please see here: https://en.wikipedia.org/wiki/List_of_HTTP_header_fields#General_format

How Has This Been Tested?

It works fine with traefik after I added the missing CRLF.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@chogata
Copy link
Member

chogata commented Jul 27, 2021

Thank you for pointing this out.

This needs to be added to "err_resp" function as well. Can you modify your commit so it contains both fixes?

@Eronana
Copy link
Contributor Author

Eronana commented Jul 27, 2021

Thank you for pointing this out.

This needs to be added to "err_resp" function as well. Can you modify your commit so it contains both fixes?

sure, i’ll update this pr tmr.

@chogata chogata merged commit df6a24e into moosefs:master Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants