Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mondrian should provide teh start and end nodes in the edge action #396

Closed
seandenigris opened this issue Aug 3, 2015 · 2 comments
Closed

Comments

@seandenigris
Copy link
Contributor

seandenigris commented Aug 3, 2015

Originally reported on Google Code with ID 396

Right now, an edge action block takes as parameter only the model of the edge.

The model of the edge is mainly targeted to identifying the start and end node, but
it many times is 
not enough to do something with the edge afterwards.

By providing the start and end node in the action block, we take advantage of the already
computed 
nodes.

To not break existing code, an idea would be to use something similar to glamourValue
through 
which the block parameters are optional.

Reported by tudor.girba on 2010-05-05 23:17:38

@seandenigris
Copy link
Contributor Author

seandenigris commented Aug 3, 2015

I started to work on this (testHandlerOnEdge). However, I am unsure for few things.

view interaction on: MOMouseDown do: [ :v | ... ]

What v is supposed to be? The announcement or the value on which one has clicked? 
It has to be the value I believe. However, it may brake already existing code. We could
leave it like this, and introduce on:withValueDo: 

What do you think?

Cheers,
Alexandre


Reported by alexandre.bergel on 2010-11-19 20:42:02

@seandenigris
Copy link
Contributor Author

seandenigris commented Aug 3, 2015

In Roassal, the block in on:do: receives an event, that contains the model. Much cleaner
than in Mondrian!

Reported by alexandre.bergel on 2012-10-03 20:20:14

  • Status changed: WontFix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant