Merge pull request #2293 from arian/fix-2289-setproperty-tostring

Fixes #2289 - use '' + value for values passed into setProperty
mootools · Feb 16, 2012 · 74e3479 · 74e3479
2 parents b060531 + 330b1d4
commit 74e3479
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/Source/Element/Element.js b/Source/Element/Element.js
@@ -631,7 +631,7 @@ Element.implement({
 				if (pollutesGetAttribute) delete attributeWhiteList[name];
 				/* </ltIE9> */
 			} else {
-				this.setAttribute(name, value);
+				this.setAttribute(name, '' + value);
 				/* <ltIE9> */
 				if (pollutesGetAttribute) attributeWhiteList[name] = true;
 				/* </ltIE9> */

diff --git a/Specs/1.4client/Element/Element.js b/Specs/1.4client/Element/Element.js
@@ -79,6 +79,15 @@ describe('Element', function(){
 
 		});
 
+		describe('value as object with toString()', function(){
+
+			it('should call the toString() method of a passed object', function(){
+				var a = new Element('a').set('href', {toString: function(){ return '1'; }});
+				expect(a.get('href')).toEqual('1');
+			});
+
+		});
+
 	});
 
 	describe("Element.setProperty('type')", function(){