Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.set('href', ...) doesn't trigger toString() #2289

Closed
arian opened this issue Feb 13, 2012 · 0 comments · Fixed by #2293
Closed

.set('href', ...) doesn't trigger toString() #2289

arian opened this issue Feb 13, 2012 · 0 comments · Fixed by #2293
Labels
api bug regression
Milestone
1.4.5

Comments

@arian
Copy link
Member

arian commented Feb 13, 2012

Running the mootools-more specs, this one fails:

expect(new Element('a').set('href', new URI()).get('href')).toEqual(new URI().toString());

apparently .set('href', ...) used to call .toString() or something similar, but it doesn't anymore.
@arian arian mentioned this issue Feb 16, 2012
Merged
@arian arian closed this as completed in 330b1d4 Feb 16, 2012
cpojer added a commit to ibolmo/mootools-core that referenced this issue Feb 17, 2012
@cpojer
Merge pull request mootools#2293 from arian/fix-2289-setproperty-tost…
74e3479 
…ring

Fixes mootools#2289 - use '' + value for values passed into setProperty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api bug regression
Projects
None yet
Milestone
1.4.5
Development

Successfully merging a pull request may close this issue.

Fixes #2289 - use '' + value for values passed into setProperty arian/mootools-core
1 participant
@arian