fix #2434 - wrong calculation of offset #2437

Merged
merged 2 commits into from Aug 10, 2015

Conversation

Projects
None yet
4 participants
@rrelmy
Contributor

rrelmy commented Oct 19, 2012

Fixes the bug described in #2434

Offsets are rounded correctly now

@rrelmy

This comment has been minimized.

Show comment Hide comment
@rrelmy

rrelmy Mar 3, 2014

Contributor

Does something block this commit to be merged?

Contributor

rrelmy commented Mar 3, 2014

Does something block this commit to be merged?

@ibolmo

This comment has been minimized.

Show comment Hide comment
@ibolmo

ibolmo Mar 3, 2014

Member

Are you using sub pixels when setting the left and top?

Member

ibolmo commented Mar 3, 2014

Are you using sub pixels when setting the left and top?

@ibolmo

This comment has been minimized.

Show comment Hide comment
@ibolmo

ibolmo Mar 3, 2014

Member

Update the PR to use String.toFloat instead.

Member

ibolmo commented Mar 3, 2014

Update the PR to use String.toFloat instead.

@rrelmy

This comment has been minimized.

Show comment Hide comment
@rrelmy

rrelmy Mar 3, 2014

Contributor

The problem mostly occurs on slideshows if you use an element centered with auto margins within an element of odd width or using percents in width/padding.

The pull request has been updated.

Contributor

rrelmy commented Mar 3, 2014

The problem mostly occurs on slideshows if you use an element centered with auto margins within an element of odd width or using percents in width/padding.

The pull request has been updated.

@ibolmo

This comment has been minimized.

Show comment Hide comment
@ibolmo

ibolmo Mar 3, 2014

Member

This is going to be on hold, until we get a spec to check for this. You're welcome to add one yourself, or wait about a week to get a hold of the pending PR that reduces the complexity to test MooTools.

Member

ibolmo commented Mar 3, 2014

This is going to be on hold, until we get a spec to check for this. You're welcome to add one yourself, or wait about a week to get a hold of the pending PR that reduces the complexity to test MooTools.

@ibolmo ibolmo added bug labels Mar 3, 2014

@ibolmo ibolmo modified the milestones: 1.5.1, 1.5 Mar 3, 2014

@SergioCrisostomo SergioCrisostomo referenced this pull request in mootools/mootools-more Jun 1, 2014

Closed

Drag grid alignment does not honor scrolling. #1262

@SergioCrisostomo SergioCrisostomo modified the milestones: 1.5.2, 1.5.1 Jul 3, 2014

@ibolmo ibolmo added the incomplete label Nov 11, 2014

@rrelmy

This comment has been minimized.

Show comment Hide comment
@rrelmy

rrelmy Jul 15, 2015

Contributor

I have rebased the previous commit and written a test spec.

PhantomJS version 1.9.8 used by the karma runner is based on a webkit version released around 2011 before subpixel alignment was added to webkit.
EDIT: I broke the builds again, tested locally against phantomjs v2 …

Is a test spec needed for this change? If the browser itself does not support subpixel alignment it is just fine, but I can't think of a way to test this usefully without breaking the PhantomJS build …

If something is missing please let me know.

Contributor

rrelmy commented Jul 15, 2015

I have rebased the previous commit and written a test spec.

PhantomJS version 1.9.8 used by the karma runner is based on a webkit version released around 2011 before subpixel alignment was added to webkit.
EDIT: I broke the builds again, tested locally against phantomjs v2 …

Is a test spec needed for this change? If the browser itself does not support subpixel alignment it is just fine, but I can't think of a way to test this usefully without breaking the PhantomJS build …

If something is missing please let me know.

@kentaromiura

This comment has been minimized.

Show comment Hide comment
@kentaromiura

kentaromiura Jul 16, 2015

Member

LGTM but travis failed

Member

kentaromiura commented Jul 16, 2015

LGTM but travis failed

@SergioCrisostomo

This comment has been minimized.

Show comment Hide comment
@SergioCrisostomo

SergioCrisostomo Jul 16, 2015

Member

Travis fails on PhantomJS tests. We could add a bypass to phantom.js in the specs for this.

Member

SergioCrisostomo commented Jul 16, 2015

Travis fails on PhantomJS tests. We could add a bypass to phantom.js in the specs for this.

@rrelmy

This comment has been minimized.

Show comment Hide comment
@rrelmy

rrelmy Jul 16, 2015

Contributor

The test case has been modified to compare the result of getPosition with the output of getBoundingClientRect.
All tests pass now without testing for PhantomJS

Contributor

rrelmy commented Jul 16, 2015

The test case has been modified to compare the result of getPosition with the output of getBoundingClientRect.
All tests pass now without testing for PhantomJS

SergioCrisostomo added a commit that referenced this pull request Aug 10, 2015

Merge pull request #2437 from rrelmy/master
fix #2434 - wrong calculation of offset

@SergioCrisostomo SergioCrisostomo merged commit b1830c0 into mootools:master Aug 10, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

ickata added a commit to ickata/mootools-core that referenced this pull request Sep 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment