fix #2434 - wrong calculation of offset #2437

Merged
merged 2 commits into from Aug 10, 2015

Projects

None yet

4 participants

@rrelmy

Fixes the bug described in #2434

Offsets are rounded correctly now

@rrelmy

Does something block this commit to be merged?

@ibolmo
MooTools member

Are you using sub pixels when setting the left and top?

@ibolmo
MooTools member

Update the PR to use String.toFloat instead.

@rrelmy

The problem mostly occurs on slideshows if you use an element centered with auto margins within an element of odd width or using percents in width/padding.

The pull request has been updated.

@ibolmo
MooTools member

This is going to be on hold, until we get a spec to check for this. You're welcome to add one yourself, or wait about a week to get a hold of the pending PR that reduces the complexity to test MooTools.

@ibolmo ibolmo added bug specs labels Mar 3, 2014
@ibolmo ibolmo modified the milestone: 1.5.1, 1.5 Mar 3, 2014
@SergioCrisostomo SergioCrisostomo referenced this pull request in mootools/mootools-more Jun 1, 2014
Closed

Drag grid alignment does not honor scrolling. #1262

@SergioCrisostomo SergioCrisostomo modified the milestone: 1.5.2, 1.5.1 Jul 3, 2014
@ibolmo ibolmo added the incomplete label Nov 11, 2014
@rrelmy rrelmy pushed a commit that referenced this pull request Jul 15, 2015
Rémy add test spec for #2437 subpixel offset calculation ed2150d
@rrelmy rrelmy pushed a commit that referenced this pull request Jul 15, 2015
Rémy add test spec for #2437 subpixel offset calculation a38065f
@rrelmy

I have rebased the previous commit and written a test spec.

PhantomJS version 1.9.8 used by the karma runner is based on a webkit version released around 2011 before subpixel alignment was added to webkit.
EDIT: I broke the builds again, tested locally against phantomjs v2 …

Is a test spec needed for this change? If the browser itself does not support subpixel alignment it is just fine, but I can't think of a way to test this usefully without breaking the PhantomJS build …

If something is missing please let me know.

@kentaromiura
MooTools member

LGTM but travis failed

@SergioCrisostomo
MooTools member

Travis fails on PhantomJS tests. We could add a bypass to phantom.js in the specs for this.

@rrelmy rrelmy pushed a commit that referenced this pull request Jul 16, 2015
Rémy add test spec for #2437 subpixel offset calculation 24db871
@rrelmy rrelmy pushed a commit that referenced this pull request Jul 16, 2015
Rémy add test spec for #2437 subpixel offset calculation 6843907
@rrelmy

The test case has been modified to compare the result of getPosition with the output of getBoundingClientRect.
All tests pass now without testing for PhantomJS

@SergioCrisostomo SergioCrisostomo merged commit b1830c0 into mootools:master Aug 10, 2015

1 check passed

Details continuous-integration/travis-ci/pr The Travis CI build passed
@ickata ickata added a commit to ickata/mootools-core that referenced this pull request Sep 1, 2015
Rémy add test spec for #2437 subpixel offset calculation f8f9d0c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment