Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
fix #2434 - wrong calculation of offset #2437
referenced this pull request
Jun 1, 2014
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
I have rebased the previous commit and written a test spec.
PhantomJS version 1.9.8 used by the karma runner is based on a webkit version released around 2011 before subpixel alignment was added to webkit.
Is a test spec needed for this change? If the browser itself does not support subpixel alignment it is just fine, but I can't think of a way to test this usefully without breaking the PhantomJS build …
If something is missing please let me know.