New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2715 - Adding Microsoft Edge UA string support to Browser. #2716

Merged
merged 1 commit into from May 5, 2015

Conversation

Projects
None yet
3 participants
@arian
Member

arian commented May 5, 2015

Fixes #2715

The UA string looks like:

Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/39.0.2171.71 Safari/537.36 Edge/12.0

Also fixes platform recognition, where the wrong variable was matched,
so it did not recognize windows/linux/mac, but identified it as 'other'.

Fixes #2715 - Adding Microsoft Edge UA string support to Browser.
The UA string looks like:
  Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/39.0.2171.71 Safari/537.36 Edge/12.0

Also fixes platform recognition, where the wrong variable was matched,
so it did not recognize windows/linux/mac, but identified it as 'other'.

SergioCrisostomo added a commit that referenced this pull request May 5, 2015

Merge pull request #2716 from arian/fix-2715-edge-ua-string
Fixes #2715 - Adding Microsoft Edge UA string support to Browser.

@SergioCrisostomo SergioCrisostomo merged commit 4a824b6 into mootools:master May 5, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dreadcast

This comment has been minimized.

Show comment
Hide comment
@dreadcast

dreadcast Jul 30, 2015

Hi there,

Is there a new tag including this merged PR coming up ?

dreadcast commented Jul 30, 2015

Hi there,

Is there a new tag including this merged PR coming up ?

@SergioCrisostomo

This comment has been minimized.

Show comment
Hide comment
@SergioCrisostomo

SergioCrisostomo Jul 30, 2015

Member

@dreadcast yes, it will be 1.5.2. Will check in the devgroup if we can tag it soonish.

Member

SergioCrisostomo commented Jul 30, 2015

@dreadcast yes, it will be 1.5.2. Will check in the devgroup if we can tag it soonish.

@dreadcast

This comment has been minimized.

Show comment
Hide comment
@dreadcast

dreadcast commented Jul 30, 2015

Great !

@SergioCrisostomo

This comment has been minimized.

Show comment
Hide comment
@SergioCrisostomo

SergioCrisostomo Sep 13, 2015

Member

@dreadcast 1.5.2 is out now.
Cheers.

Member

SergioCrisostomo commented Sep 13, 2015

@dreadcast 1.5.2 is out now.
Cheers.

@dreadcast

This comment has been minimized.

Show comment
Hide comment
@dreadcast

dreadcast commented Sep 13, 2015

(y)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment