add server testing in node 0.10, 0.12 and iojs #2729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -610,7 +610,7 @@ describe('instanceOf', function(){ | |||
| }); | |||
|
|
|||
| // todo(ibolmo) | |||
| if (window.Element && Element.set) it("should return true for Element instances", function(){ | |||
| if (typeof window != 'undefined' && window.Element && Element.set) it("should return true for Element instances", function(){ | |||
There was a problem hiding this comment.
do the typeof window check in the dit definition?
|
@arian (or anyone else) can we merge this? |
| var div = document.createElement('div'); | ||
| expect(typeOf(div)).toEqual('element'); | ||
| }); | ||
|
|
||
| // todo(ibolmo) | ||
| if (window.Elements) it("should return 'elements' for Elements", function(){ | ||
| if (typeof window != 'undefined' && window.Elements) dit("should return 'elements' for Elements", function(){ |
There was a problem hiding this comment.
isn't this if included in the dit function?
arian
pushed a commit
that referenced
this pull request
Aug 23, 2015
add server testing in node 0.10, 0.12 and iojs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI testing of the server build (closes #2700).
Had to add some
xit : itin the specs because they will now run innodeenvironment anddocumentandwindoware not there.Added also some Travis optimizing and Safari 8 testing for Browser specs.
To run server specs locally we can use
grunt server.Tested all this in Travis and got green for Browser and node tests.