Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes onComplete/chaining in toElementEdge + toElementCenter #1017

Closed
wants to merge 1 commit into from
Closed

Fixes onComplete/chaining in toElementEdge + toElementCenter #1017

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions Source/Fx/Fx.Scroll.js
View file
Open in desktop
Expand Up @@ -135,7 +135,7 @@ Fx.Scroll = new Class({
if (offset && offset[axis]) to[axis] = to[axis] + offset[axis]; if (offset && offset[axis]) to[axis] = to[axis] + offset[axis];
}, this); }, this);


if (to.x != scroll.x || to.y != scroll.y) this.start(to.x, to.y); this.start(to.x, to.y);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meleyal Could you fix the indent here and under?
We are reviewing all PR's before release of 1.5 and this one seems like a good idea.

PS.- sorry this got forgotten in the PR queue

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in a new PR here: #1317

return this; return this;
}, },


Expand All @@ -156,7 +156,7 @@ Fx.Scroll = new Class({
if (offset && offset[axis]) to[axis] = to[axis] + offset[axis]; if (offset && offset[axis]) to[axis] = to[axis] + offset[axis];
}, this); }, this);


if (to.x != scroll.x || to.y != scroll.y) this.start(to.x, to.y); this.start(to.x, to.y);
return this; return this;
} }


Expand Down