fix regex to not mix self closing tags #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -95,8 +95,8 @@ var walk = function(string, replacements){ | |||
| }; | |||
|
|
|||
| var getRegexForTag = function(tag, contents){ | |||
| tag = tag || ''; | |||
| var regstr = contents ? "<" + tag + "(?!\\w)[^>]*>([\\s\\S]*?)<\/" + tag + "(?!\\w)>" : "<\/?" + tag + "([^>]+)?>"; | |||
| tag = tag || (contents ? '': '\\w+'); | |||
|
Could you elaborate the change? |
SergioCrisostomo
force-pushed
the
fix-1022
branch
from
cdd7f90
to
b171c49
Compare
|
@arian sure, should have done that in the first place, sorry. This change only applies to cases where to and in cases where As it was So the first alternative in the new regex suggestion is for simpler tags (closing or self-closing), and the second alternative is for self-closing, opening, and tags with attributes. This way it will never match a letter after the |
|
👍 |
SergioCrisostomo
force-pushed
the
fix-1022
branch
from
b171c49
to
bd14bbb
Compare
SergioCrisostomo
added a commit
that referenced
this pull request
Oct 27, 2015
fix regex to not mix self closing tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1022