add sort order to onSort function arguments #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,7 +40,7 @@ HtmlTable Method: constructor | |||
|
|
|||
| ### Events | |||
|
|
|||
| * sort - callback executed when a column is sorted; passed the *tbody* and the index of the column sorted. | |||
| * sort - callback executed when a column is sorted; passed the *tbody*, the index of the column sorted and *reversed* to know the sorting direction. | |||
There was a problem hiding this comment.
this isn't super clear. I'd do:
sort - callback executed when a column is sorted; passed the *tbody* (Element), the index of the column sorted (Integer) and which direction the table is sorted ("asc" or "desc").
SergioCrisostomo
force-pushed
the
sort-direction
branch
from
2393a97
to
58c256c
Compare
SergioCrisostomo
added a commit
that referenced
this pull request
Oct 27, 2015
add sort order to onSort function arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sorting a table the
onSortfunction does not tell which direction the sort happens.Following @oskarkrawczyk 's work I made this PR to fix that.
This would make possible to know if if the reversed state is
trueorfalse.fixes #1193