1.3wip element pin jumps #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://mootools.lighthouseapp.com/projects/24057-mootoolsmore/tickets/395-elementpin-jumps-on-initialize#ticket-395-3 - the problem was that the pinned element was getting it's position from it's offest parent -- but if that offset element had a position of relative its percieved position would be different that of the body (which is really what it should be relative to when setting to position fixed.) that was a terrible explanation, i hope that made a little sense...
|
here's a link to the ticket... https://mootools.lighthouseapp.com/projects/24057-mootoolsmore/tickets/395-elementpin-jumps-on-initialize#ticket-395-3 |
|
did you run the test locally? |
|
i did :) |
|
pulled to 1.3 and 1.2 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will also fix the jump in 1.2 -- not sure if you want to apply this there too...