Skip to content

Commit

Permalink
docs: add Github issue link to ignored .ValidAmountForCodes
Browse files Browse the repository at this point in the history
Issue: #1170
Issue: #1171
Issue: #1172
  • Loading branch information
adamdecaf committed Feb 13, 2023
1 parent 6e26a9d commit d3dbe93
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion batchACK.go
Expand Up @@ -61,7 +61,7 @@ func (batch *BatchACK) Validate() error {
return batch.Error("TransactionCode", ErrBatchTransactionCode, entry.TransactionCode)
}
// // Verify the Amount is valid for SEC code and TransactionCode
// if err := batch.ValidAmountForCodes(entry); err != nil { // TODO(adam):
// if err := batch.ValidAmountForCodes(entry); err != nil { // TODO(adam): https://github.com/moov-io/ach/issues/1170
// return err
// }
// Verify the TransactionCode is valid for a ServiceClassCode
Expand Down
2 changes: 1 addition & 1 deletion batchATX.go
Expand Up @@ -78,7 +78,7 @@ func (batch *BatchATX) Validate() error {
return batch.Error("AddendaCount", NewErrBatchExpectedAddendaCount(len(entry.Addenda05), addendaRecords))
}
// // Verify the Amount is valid for SEC code and TransactionCode
// if err := batch.ValidAmountForCodes(entry); err != nil { // TODO(adam):
// if err := batch.ValidAmountForCodes(entry); err != nil { // TODO(adam): https://github.com/moov-io/ach/issues/1170
// return err
// }
// Verify the TransactionCode is valid for a ServiceClassCode
Expand Down
2 changes: 1 addition & 1 deletion batchDNE.go
Expand Up @@ -70,7 +70,7 @@ func (batch *BatchDNE) Validate() error {
return batch.Error("AddendaCount", NewErrBatchAddendaCount(len(entry.Addenda05), 1))
}
// // Verify the Amount is valid for SEC code and TransactionCode
// if err := batch.ValidAmountForCodes(entry); err != nil { // TODO(adam):
// if err := batch.ValidAmountForCodes(entry); err != nil { // TODO(adam): https://github.com/moov-io/ach/issues/1171
// return err
// }
// Verify the TransactionCode is valid for a ServiceClassCode
Expand Down
2 changes: 1 addition & 1 deletion batchENR.go
Expand Up @@ -71,7 +71,7 @@ func (batch *BatchENR) Validate() error {
return batch.Error("TransactionCode", ErrBatchTransactionCode, entry.TransactionCode)
}
// // Verify the Amount is valid for SEC code and TransactionCode
// if err := batch.ValidAmountForCodes(entry); err != nil { // TODO(adam):
// if err := batch.ValidAmountForCodes(entry); err != nil { // TODO(adam): https://github.com/moov-io/ach/issues/1172
// return err
// }
// Verify the TransactionCode is valid for a ServiceClassCode
Expand Down

0 comments on commit d3dbe93

Please sign in to comment.