Skip to content
This repository has been archived by the owner on Aug 26, 2022. It is now read-only.

Get customer documents empty response is null #129

Closed
joshsadler opened this issue Aug 27, 2020 · 4 comments · Fixed by #207
Closed

Get customer documents empty response is null #129

joshsadler opened this issue Aug 27, 2020 · 4 comments · Fixed by #207
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@joshsadler
Copy link
Member

The response body for GET /customers/:customerID/documents is an array of objects, but when there are no documents the response is null instead of an empty array.

@joshsadler joshsadler added the bug Something isn't working label Aug 27, 2020
@adamdecaf adamdecaf added good first issue Good for newcomers help wanted Extra attention is needed labels Sep 3, 2020
@adamdecaf
Copy link
Member

FYI #102 is an example of how to fix this bug.

@adamdecaf
Copy link
Member

@jmbrown412 was this on your plate to do?

@jmbrown412
Copy link
Contributor

jmbrown412 commented Sep 12, 2020 via email

@adamdecaf
Copy link
Member

Was there a fix for this pushed? I'm seeing the bug still on master

https://github.com/moov-io/customers/blob/master/pkg/documents/documents.go#L263

@adamdecaf adamdecaf added this to In progress in Current Work Sep 25, 2020
@adamdecaf adamdecaf added this to the v0.5 Release milestone Sep 28, 2020
@adamdecaf adamdecaf assigned adamdecaf and unassigned jmbrown412 Sep 29, 2020
@adamdecaf adamdecaf moved this from In progress to Done in Current Work Sep 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
No open projects
Current Work
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants