Skip to content
This repository has been archived by the owner on Aug 26, 2022. It is now read-only.

accounts: need "rejected" type status? #157

Closed
adamdecaf opened this issue Sep 15, 2020 · 6 comments · Fixed by #246
Closed

accounts: need "rejected" type status? #157

adamdecaf opened this issue Sep 15, 2020 · 6 comments · Fixed by #246
Assignees
Labels
enhancement New feature or request

Comments

@adamdecaf
Copy link
Member

Customers Version: v0.5.0-dev

Now that Accounts have their own OFAC searches (on HolderName) they can be rejected for a positive match. We need to reject that account.

See the Customers flow.
https://github.com/moov-io/customers/blob/v0.5.0-dev2/cmd/server/approval_ofac.go#L139-L148

@adamdecaf adamdecaf added the enhancement New feature or request label Sep 15, 2020
@adamdecaf
Copy link
Member Author

Due to how the OpenAPI generator creates "enums" for Go I don't think we can call it Rejected. The generator will create to const REJECTED = "rejected" values and Go won't be able to compile those.

We need to find a term for this or figure out how to share REJECTED.
Customer Status: https://github.com/moov-io/customers/blob/master/pkg/client/model_customer_status.go

@adamdecaf adamdecaf added this to To do in Current Work Sep 16, 2020
@vxio
Copy link
Member

vxio commented Sep 24, 2020

@adamdecaf this might fix your issue OpenAPITools/openapi-generator#535 (comment)

@vxio vxio self-assigned this Sep 24, 2020
@adamdecaf
Copy link
Member Author

Sweet! 4.3.2 doesn't seem to exist on DockerHub, so I'm not sure if we need to request a release or something.

@adamdecaf
Copy link
Member Author

adamdecaf commented Sep 24, 2020

I tried this on a branch #193 and wish we could customize this a bit more.

CUSTOMER_INDIVIDUAL would be a lot nicer.

// CustomerStatus State of the customer
type CustomerStatus string

// List of CustomerStatus
const (
	CUSTOMERSTATUS_DECEASED     CustomerStatus = "Deceased"
	CUSTOMERSTATUS_REJECTED     CustomerStatus = "Rejected"
	CUSTOMERSTATUS_UNKNOWN      CustomerStatus = "Unknown"
	CUSTOMERSTATUS_RECEIVE_ONLY CustomerStatus = "ReceiveOnly"
	CUSTOMERSTATUS_VERIFIED     CustomerStatus = "Verified"
)

@vxio
Copy link
Member

vxio commented Sep 24, 2020

Yeah, one of the downsides of code gen 😅

@vxio vxio moved this from To do to In progress in Current Work Sep 28, 2020
@adamdecaf
Copy link
Member Author

adamdecaf commented Oct 7, 2020

@vxio can we chat on this? There should be a failure status for accounts along with a "frozen" status. I think we just need to prefix the generated values for now, but I want to look at our options.

Edit: A Customer also needs a frozen status - this will initially be for rejected OFAC hits.

See: moov-io/paygate#579

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Current Work
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants