Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

js2-forward-sexp doesn't work when the buffer is narrowed. #114

Closed
milkypostman opened this issue Sep 19, 2013 · 2 comments
Closed

js2-forward-sexp doesn't work when the buffer is narrowed. #114

milkypostman opened this issue Sep 19, 2013 · 2 comments

Comments

@milkypostman
Copy link

parse-partial-sexp is getting called with a range that is outside of the narrowed buffer and this causes problems. I'm not sure what the fix is because I don't have a ton of experience w/ this codebase.

this is with the latest head version.
@dgutov
Copy link
Collaborator

dgutov commented Sep 19, 2013

We do a widen before maybe parsing the buffer, in order to counteract narrowing by blink-matching-open (#63).
Maybe we should just extend this save-restriction block to the whole function body.

@dgutov dgutov closed this as completed in de0fe6d Sep 20, 2013
@dgutov
Copy link
Collaborator

dgutov commented Sep 20, 2013

That seems to do it.

@dgutov dgutov mentioned this issue Nov 26, 2013
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@milkypostman @dgutov