Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shows warnings where they shouldn't be #63

Closed
katspaugh opened this issue Sep 3, 2012 · 5 comments
Closed

Shows warnings where they shouldn't be #63

katspaugh opened this issue Sep 3, 2012 · 5 comments

Comments

@katspaugh
Copy link

Hi!

Emacs now warns, that a semicolon is missed, in places where no semicolon needed.

Imgur

Imgur

When I rolled back to f8cb9c5, the problem disappeared.

@dgutov
Copy link
Collaborator

dgutov commented Sep 3, 2012

Does it always do that? I just typed the second snippet, and it didn't underline anything.
What if you delete some part of the text, and then type it again?

I remember seeing a similar behavior once yesterday, then I switched to branch emacs24 (which contains all the latest changes, so they're probably not at fault), and it went away. Now I can't reproduce it with master either.

@katspaugh
Copy link
Author

Dmitry,

Yes, it's always warning in the second snippet (the text attached below). I can reproduce it with emacs -Q as well:

Imgur

If you type a space after the last function, the highlighting becomes correct.

On the master branch of js2-mode and Emacs is GNU Emacs 24.2.1 (no GUI).

Whiteboard.prototype.observable = {
    fireEvent: function () {},
    on: function () {}
};

@dgutov
Copy link
Collaborator

dgutov commented Sep 3, 2012

Found it. Looks like blink-matching-paren strikes back.
The warnings should only appear when you actually type a closing paren, not after opening an existing file, for example. This should fix it.

@dgutov dgutov closed this as completed in 47dd40b Sep 3, 2012
@katspaugh
Copy link
Author

Thanks, Dmitry!

@dgutov
Copy link
Collaborator

dgutov commented Sep 4, 2012

No problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants