Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hok no longer receives keypress events because bug https://bugzilla.mozilla.org/show_bug.cgi?id=501496 has been resolved #124

Closed
diegov opened this issue Aug 4, 2013 · 1 comment

Comments

@diegov
Copy link

diegov commented Aug 4, 2013

Hi,

A fix for https://bugzilla.mozilla.org/show_bug.cgi?id=501496 was released in a Firefox nightly build a few days ago, which caused Hok to stop working, because it calls event.preventDefault() on the keydown event, which now causes the following keypress to be cancelled.

I've patched it locally by removing the preventDefault call in the preventEvent Hok function, which works fine in my setup, but I don't know whether it would be a valid solution in all cases. It works OK with eg. inputs since we're still preventing the keypress default, but I haven't done much testing in other scenarios.

In any case, the FF bug fix will break Hok as soon as it gets merged into FF stable, so a Hok change will probably be necessary.

Cheers!

@mooz mooz closed this as completed in 404e2b4 Aug 6, 2013
@mooz
Copy link
Owner

mooz commented Aug 6, 2013

Thank you for very informative comment. As just removing preventDefault is problematic, I made a little modification to keyhandlers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants