Avoid asynchronous callback on ReconnectableConnection, too. #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
moozzyk
added a commit
that referenced
this pull request
Jan 4, 2023
This refactoring f4558f6 effectively removed the fix introduced in #244 and the client started deadlocking if a keep alive was sent during reconnects. To avoid deadlocks the callback will be now scheduled asynchronously on the callback queue if there is an error due to a reconnect. For all other cases ReconnectableConnection will rely on the fact that the underling HttpConnection already schedules callbacks to be executed asynchronously. Fixes: #264
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to #238
After fixing that bug, we're now seeing a deadlock in our analytics in
ReconnectableConnection. For exactly the same reasons asHttpConnection, an asynchronous callback fromReconnectableConnectioncan cause a deadlock with thekeepAlivePingso thesendDidCompleteshould always be sent asynchronously.