Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ability to specify the URLSessionWebSocketTask maximumMessageSize #291

Merged
merged 2 commits into from Dec 9, 2023
Merged

add ability to specify the URLSessionWebSocketTask maximumMessageSize #291

merged 2 commits into from Dec 9, 2023

Conversation

aj-bartocci
Copy link
Contributor

  • exposes maximumWebsocketMessageSize via HttpConnectionOptions so that maximumMessageSize can be set on URLSessionWebSocketTask
  • this is needed to be able to set larger buffer sizes than Apple's default

@moozzyk
Copy link
Owner

moozzyk commented Dec 9, 2023 •
edited

Thanks for your PR! This was on my list and now I no longer need to worry about this!

@moozzyk moozzyk merged commit 2380f02 into moozzyk:master Dec 9, 2023
@aj-bartocci
Copy link
Contributor Author

@moozzyk can you cut a new patch release so I can pull this in by semantic version?

@moozzyk
Copy link
Owner

moozzyk commented Dec 13, 2023

@aj-bartocci - I will try to do this later this week.

@moozzyk
Copy link
Owner

moozzyk commented Dec 17, 2023

@aj-bartocci - Shipped 1.1.0 that contains your changes today. Thanks again for your PR!

@aj-bartocci
Copy link
Contributor Author

no prob, thanks for the new version!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aj-bartocci @moozzyk