Skip to content
This repository has been archived by the owner on Dec 7, 2020. It is now read-only.

More logical playlist reload #99

Closed
wants to merge 1 commit into from

Conversation

DelusionalLogic
Copy link

I had a problem with playlists not loading. While debugging this I found this code. While it might help avoid some playlist reloads it also makes the reload time completely illogical.

I've removed the timing bits, so it now refreshes at the time you tell it to. I've also made it wait for the lock, to again ensure the user that it will refresh at the first opportunity. This has the happy sideeffect that it enables the playlists to refresh on startup. This technically creates a race condition (because this function might run before the library refresh is initiated. To alleviate that I've created a boolean that is set when the library is loaded.

@jcass77
Copy link
Member

jcass77 commented Dec 3, 2015

I think the intention is for the user to just set the refresh_xxx configuration parameters to their personal preference.

@DelusionalLogic
Copy link
Author

Sure, that what i want. An thats what this ensures.

Before you set the time, but then it just ignored it because what if we are about to update the songs or we just updated the songs. I'm guessing this was made because updating the music once updated the playlists, that is not the case right now.

With this change, when you set when it should update it actually updates at about that time, instead of just dropping the request.

It should also be noted that playlists actually don't load without this patch for me.

@belak
Copy link
Contributor

belak commented Jul 7, 2016

Right now there's a problem with useful data returned by the API being ignored. I did my best to fix this in #130 so this shouldn't be needed any more.

@belak belak closed this Jul 7, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants