Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: MPD-0.21 Search/Find Expressions #52

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Commits on Jan 14, 2022

  1. Document FILTER syntax for Database Commands

    These will be implemented in the following commit(s).
    
    Descriptions are quoted from the MPD Protocol documentation, v0.21.4.
    https://web.archive.org/web/20190104200400/https://www.musicpd.org/doc/html/protocol.html
    girst committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    fc52b4c View commit details
    Browse the repository at this point in the history
  2. Implement parsing Filter Expressions

    Notes:
    - file(name) only has the '==' operator documented, but mpd(1) accepts
      all tag-filter-operators for it.
    - AudioFormat only documents '==' and '=~', which is not a regex, but
      accepts '*' wildcards. We don't support this tag type.
    - in '(...AND...)', MPD enforces at least two subexpressions, we are
      laxer and allow a single one as well (i.e., just an extra pair of
      parentheses around an expression).
    - where possible, exact error messages from MPD 0.23 have been used.
    girst committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    36985e0 View commit details
    Browse the repository at this point in the history
  3. simplify parsing by removing unsupported operators

    Mopidy can't handle not-matching, so no need to implement this. This is
    a seperate commit, so if in the future Mopidy gains this ability, it can
    be easily reintroduced.
    girst committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    ecc666c View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2022

  1. pass (base 'VALUE') to LibraryController.search(uris=)

    Note that we support OR-ing multiple base URIS, which MPD doesn't.
    girst committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    a4852bd View commit details
    Browse the repository at this point in the history