-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sp_session_starred_create segmentation fault #60
Comments
This sounds fantastic. Sounds very much like something not too hard to fix. I'll have a look at this right away :-) |
I get the same segfault, or at least a very similar one (http://ix.io/k6i), when sending "status\nlsinfo" and sometimes when sending just "lsinfo" to the MPD interface. The lsinfo command has to be without arguments or with just / as the argument. It doesn't happen if I give another argument to lsinfo, I guess because it doesn't load the playlists then. I tried running mopidy with a pdb breakpoint in get_starred and stepped through the code until I got to the segfault. Not sure if it helps, but here's the output: http://ix.io/k6j |
May fix segfault reported in mopidy/mopidy-spotify#60.
I believe this might have been fixed by jodal/pyspotify@2ed3d2a. Can you retest? |
I quickly tested the websocket case and I still get a segfault although it's now slightly different. I have not seen this longer version before.
|
Our debugging indicates that using a mix of sp_session_starred_for_user_create(session, username) and sp_playlist_create(session, link) to get starred playlists consistently causes segfaults. May fix segfault reported in mopidy/mopidy-spotify#60.
jodal/pyspotify@dab0c67 adds another potential fix to this. Please retest! :-) |
So far so good! |
Ok, then we close this :-) |
Every time I connect to the Mopidy websocket with a webclient, Mopidy will crash with "Segmentation fault (core dumped)". I think this is caused by JsonRpcInspector finding
get_playlists
through theplaylists
property whencore.describe
is called.There is a verbose log at http://dpaste.com/1PD98M9. Removing my Spotify cache files doesn't appear to have any effect.
If I use mpc instead of a webclient, then all is fine up until I terminate Mopidy, at which point I get a different segmentation fault. I think the two seg faults are related since I found that changing
PlaylistsController.get_playlists
toinclude_tracks=False
fixed everything and there were no seg faults in either scenario.So my current best guess is this somehow related to the sp_playlist reference in a
PlaylistTrack
. Or that could be a red herring...The text was updated successfully, but these errors were encountered: