Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 #233

Merged
merged 16 commits into from Nov 18, 2019
Merged

Python3 #233

merged 16 commits into from Nov 18, 2019

Conversation

kingosticks
Copy link
Member

Fixes #231

@kingosticks kingosticks added this to the v3.x milestone Nov 16, 2019
@kingosticks kingosticks self-assigned this Nov 16, 2019
setup.cfg Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
mopidy_spotify/translator.py Outdated Show resolved Hide resolved
mopidy_spotify/translator.py Outdated Show resolved Hide resolved
mopidy_spotify/web.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
mopidy_spotify/translator.py Outdated Show resolved Hide resolved
@jodal jodal modified the milestones: v3.x, v4.0 Nov 17, 2019
@codecov
Copy link

codecov bot commented Nov 18, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@5eb11f2). Click here to learn what that means.
The diff coverage is 96.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #233   +/-   ##
==========================================
  Coverage           ?   96.32%           
==========================================
  Files              ?       13           
  Lines              ?      979           
  Branches           ?        0           
==========================================
  Hits               ?      943           
  Misses             ?       36           
  Partials           ?        0
Impacted Files Coverage Δ
mopidy_spotify/countries.py 100% <ø> (ø)
mopidy_spotify/backend.py 98.95% <100%> (ø)
mopidy_spotify/library.py 100% <100%> (ø)
mopidy_spotify/playlists.py 94.28% <100%> (ø)
mopidy_spotify/search.py 94.87% <100%> (ø)
mopidy_spotify/translator.py 99.29% <100%> (ø)
mopidy_spotify/playback.py 100% <100%> (ø)
mopidy_spotify/images.py 100% <100%> (ø)
mopidy_spotify/lookup.py 100% <100%> (ø)
mopidy_spotify/utils.py 100% <100%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5eb11f2...ef3d728. Read the comment docs.

@kingosticks kingosticks marked this pull request as ready for review November 18, 2019 00:34
@kingosticks
Copy link
Member Author

This works well except for the pyspotify issue when stopping Mopidy:

INFO     2019-11-18 00:39:03,182 [30307:MainThread] mopidy.commands
  Stopping Mopidy backends
INFO     2019-11-18 00:39:03,225 [30307:MainThread] mopidy.commands
  Stopping Mopidy audio
From callback for ffi.gc <cdata 'struct sp_artist *' 0x7f59a4028810>:
Traceback (most recent call last):
  File "/home/nick/.virtualenvs/mopidy3/lib/python3.7/site-packages/spotify/__init__.py", line 57, in wrapper
AttributeError: __enter__
From callback for ffi.gc <cdata 'struct sp_artist *' 0x7f59a4028c00>:
Traceback (most recent call last):
  File "/home/nick/.virtualenvs/mopidy3/lib/python3.7/site-packages/spotify/__init__.py", line 57, in wrapper
AttributeError: __enter__
From callback for ffi.gc <cdata 'struct sp_artist *' 0x7f59a001c400>:
Traceback (most recent call last):
  File "/home/nick/.virtualenvs/mopidy3/lib/python3.7/site-packages/spotify/__init__.py", line 57, in wrapper
AttributeError: __enter__
From callback for ffi.gc <cdata 'struct sp_album *' 0x7f59a4028730>:
Traceback (most recent call last):
  File "/home/nick/.virtualenvs/mopidy3/lib/python3.7/site-packages/spotify/__init__.py", line 57, in wrapper
AttributeError: __enter__
From callback for ffi.gc <cdata 'struct sp_album *' 0x7f59a4028b20>:
Traceback (most recent call last):
  File "/home/nick/.virtualenvs/mopidy3/lib/python3.7/site-packages/spotify/__init__.py", line 57, in wrapper
AttributeError: __enter__
From callback for ffi.gc <cdata 'struct sp_album *' 0x7f59a001c320>:
Traceback (most recent call last):
  File "/home/nick/.virtualenvs/mopidy3/lib/python3.7/site-packages/spotify/__init__.py", line 57, in wrapper
AttributeError: __enter__
From callback for ffi.gc <cdata 'struct sp_track *' 0x7f59a0009d50>:
Traceback (most recent call last):
  File "/home/nick/.virtualenvs/mopidy3/lib/python3.7/site-packages/spotify/__init__.py", line 57, in wrapper
AttributeError: __enter__
From callback for ffi.gc <cdata 'struct sp_track *' 0x7f59a0015840>:
Traceback (most recent call last):
  File "/home/nick/.virtualenvs/mopidy3/lib/python3.7/site-packages/spotify/__init__.py", line 57, in wrapper
AttributeError: __enter__
From callback for ffi.gc <cdata 'struct sp_track *' 0x7f59a0015d10>:
Traceback (most recent call last):
  File "/home/nick/.virtualenvs/mopidy3/lib/python3.7/site-packages/spotify/__init__.py", line 57, in wrapper
AttributeError: __enter__

@jodal jodal merged commit 76bc9bb into mopidy:develop Nov 18, 2019
@kingosticks kingosticks deleted the python3 branch January 6, 2021 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port mopidy-spotify to Python 3
2 participants