config: Add private_session config #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def test_on_start_configures_private_session(spotify_mock, config): | ||
| session = spotify_mock.Session.return_value | ||
| private_session_mock = mock.PropertyMock() | ||
| type(session).private_session = private_session_mock |
There was a problem hiding this comment.
The test fails, probably due to this line adding the mock to the wrong object. It's session.social.private_session, not session.private_session.
There was a problem hiding this comment.
Thanks for the fast response! Yeah, my bad, fixed in dfa3d3b and the CI build is passing now.
jodal
added
the
C-enhancement
jodal
added a commit
that referenced
this pull request
Jan 18, 2015
config: Add private_session config
|
Thanks for a lovely pull request: a single specific change, with tests, docs, and perfect formatting. :-) |
|
Heh, just a shame about the silly failing test really 馃槈 Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. Thanks so much for Mopidy and the Spotify extension!
I occasionally find myself in situations in which I'd prefer my Spotify session to be private. This PR adds a
private_sessionconfig value which can be used to do just that 馃槃