Release v3.1.0

.circleci/config.yml

@@ -7,17 +7,19 @@ workflows:
   version: 2
   test:
     jobs:
+      - py39
       - py38
       - py37
       - black
       - check-manifest
       - docs
       - flake8
+      - isort
 
 jobs:
-  py38: &test-template
+  py39: &test-template
     docker:
-      - image: mopidy/ci-python:3.8
+      - image: mopidy/ci-python:3.9
     steps:
       - checkout
       - restore_cache:
@@ -40,6 +42,11 @@ jobs:
       - store_test_results:
           path: test-results
 
+  py38:
+    <<: *test-template
+    docker:
+      - image: mopidy/ci-python:3.8
+
   py37:
     <<: *test-template
     docker:
@@ -52,3 +59,5 @@ jobs:
   docs: *test-template
 
   flake8: *test-template
+
+  isort: *test-template

.github/ISSUE_TEMPLATE.md

@@ -1,3 +1,5 @@
 Please use https://discourse.mopidy.com/ for support questions.
 
-GitHub Issues should only be used for confirmed problems with Mopidy and well-defined feature requests.
+GitHub Issues should only be used for confirmed problems with Mopidy and well-defined feature requests. if you are not sure where to post, post at https://discourse.mopidy.com/ first.
+
+If you are reporting a problem, please read through https://docs.mopidy.com/en/latest/troubleshooting/ and ensure your post includes `deps`, `config`, and an appropriately verbose log showing the problem. Please also include detailed steps on how to reproduce the problem.

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,29 @@
+---
+name: Bug report
+about: Create a report to help us improve
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+If you are not sure about anything below then please post on our [forum](https://discourse.mopidy.com/) first.
+
+**Describe the bug**
+A clear and concise description of what the bug is. Is this specific to a particular Backend (e.g. Mopidy-Spotify), Frontend (e.g. Mopidy-MPD) or client?
+
+**To reproduce**
+Steps to reproduce the behaviour including any error messages that occur. 
+
+**Expected behaviour**
+A clear and concise description of what you expected to happen.
+
+**Environment (please complete the following information):**
+- Operating system (e.g. Debian Buster, Ubuntu 20.04)
+ - [Running Mopidy](https://docs.mopidy.com/en/latest/running/) as a service or in the terminal?
+ - Your config (output of `sudo mopidyctl config`)
+ - Software versions (output of `sudo mopidyctl deps`)
+ - Any specific hardware (e.g. an exotic USB soundcard)
+
+**Additional context**
+Add any other context about the problem here. If appropriate, upload an [appropriately verbose](https://docs.mopidy.com/en/latest/troubleshooting/#debug-logging) log file showing the bug.

.github/ISSUE_TEMPLATE/config.yml

@@ -0,0 +1,5 @@
+blank_issues_enabled: true
+contact_links:
+  - name: Mopidy Discourse Forum
+    url: https://discourse.mopidy.com/
+    about: Please ask and answer questions here.

.github/ISSUE_TEMPLATE/extension-request.md

@@ -0,0 +1,12 @@
+---
+name: Extension Request
+about: Share your idea for a new Mopidy Extension.
+title: ''
+labels: C-extension-request
+assignees: ''
+
+---
+
+Please explain your idea and provide any information on how the extension might be implemented. See [here](https://discourse.mopidy.com/t/supporting-new-streaming-services-and-other-music-sources/22) for more information.
+
+Note: these issues are closed as they cannot be fixed in Mopidy itself. However, they will be added to our [Extension wishlist](https://github.com/mopidy/mopidy/issues?utf8=%E2%9C%93&q=label%3AC-extension-request+) label for potential authors/collaborators to find and discuss.

.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,10 @@
+---
+name: Feature request
+about: Suggest an idea for this project
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+Mopidy's GitHub Issues are reserved for well-defined feature requests. If this is a more general idea or question, please post on the [forum](https://discourse.mopidy.com) first.

.github/workflows/release.yml

@@ -0,0 +1,23 @@
+name: Release
+
+on:
+  release:
+    types: [published]
+
+jobs:
+  release:
+    runs-on: ubuntu-20.04
+
+    steps:
+    - uses: actions/checkout@v2
+    - uses: actions/setup-python@v2
+      with:
+        python-version: '3.9'
+    - name: "Install dependencies"
+      run: python3 -m pip install build
+    - name: "Build package"
+      run: python3 -m build
+    - uses: pypa/gh-action-pypi-publish@v1.4.1
+      with:
+        user: __token__
+        password: ${{ secrets.PYPI_TOKEN }}

.mailmap

@@ -13,9 +13,10 @@ Alexandre Petitjean <alpetitjean@gmail.com>
 Alexandre Petitjean <alpetitjean@gmail.com> <alexandre.petitjean@lne.fr>
 Javier Domingo Cansino <javierdo1@gmail.com> <javier.domingo@fon.com>
 Lasse Bigum <lasse@bigum.org> <l.bigum@samsung.com>
-Nick Steel <nsteel@fastmail.com> <kingosticks@gmail.com>
-Nick Steel <nsteel@fastmail.com> <nickasteel@gmail.com>
-Nick Steel <nsteel@fastmail.com> <nick.steel@nokia.com>
+Nick Steel <nick@nsteel.co.uk> <kingosticks@gmail.com>
+Nick Steel <nick@nsteel.co.uk> <nickasteel@gmail.com>
+Nick Steel <nick@nsteel.co.uk> <nick.steel@nokia.com>
+Nick Steel <nick@nsteel.co.uk> <nsteel@fastmail.com>
 Janez Troha <janez.troha@gmail.com> <dz0ny@users.noreply.github.com>
 Janez Troha <janez.troha@gmail.com> <dz0ny@ubuntu.si>
 Luke Giuliani <luke@giuliani.com.au>
@@ -44,3 +45,5 @@ Matthieu Melquiond <matt.llvw@gmail.com>
 Geoffroy Youri Berret <kaliko@azylum.org>
 Hugo van Kemenade <hugovk@users.noreply.github.com>
 Tobias Girstmair <girst@users.noreply.github.com>
+Jonathan Jefferies <jonathan@jjok.co.uk>
+Matthew H. Flamm <matthewhflamm@gmail.com>

AUTHORS

@@ -16,7 +16,7 @@
 - Jeremy B. Merrill <jeremybmerrill@gmail.com>
 - Adam Rigg <adam@adamrigg.id.au>
 - Ernst Bammer <herr.ernst@gmail.com>
-- Nick Steel <nsteel@fastmail.com>
+- Nick Steel <nick@nsteel.co.uk>
 - Zan Dobersek <zandobersek@gmail.com>
 - Thomas Refis <refis.thomas@gmail.com>
 - Janez Troha <janez.troha@gmail.com>
@@ -120,3 +120,11 @@
 - Hugo van Kemenade <hugovk@users.noreply.github.com>
 - Tobias Girstmair <girst@users.noreply.github.com>
 - Jakub Fijałkowski <kuba@codinginfinity.me>
+- Jonathan Jefferies <jonathan@jjok.co.uk>
+- Prajjwal Nijhara <prajjwalnijhara@gmail.com>
+- Asmi Jafar <47150162+asmijafar20@users.noreply.github.com>
+- Saloni Gupta <60188408+salonigupta1@users.noreply.github.com>
+- Parth Verma <v.parth98@gmail.com>
+- Flamm, Matthew H <matthewhflamm@gmail.com>
+- Matthew Gamble <git@matthewgamble.net>
+- very-amused <very-amused@pm.me>

MANIFEST.in

@@ -1,5 +1,6 @@
 include *.py
 include *.rst
+include *.toml
 include .mailmap
 include .readthedocs.yml
 include AUTHORS

docs/changelog.rst

@@ -9,6 +9,27 @@ This changelog is used to track all major changes to Mopidy.
 For older releases, see :ref:`history`.
 
 
+v3.1.0 (2020-12-16)
+===================
+
+- Add Python 3.9 to our test matrix.
+
+- Add :meth:`mopidy.backend.PlaybackProvider.should_download` which can be
+  implemented by playback providers that want to use GStreamer's download
+  buffering strategy for their URIs. (PR: :issue:`1888`)
+
+- Audio: Fix memory leak when converting GStreamer ``sample`` type tags.
+  (Fixes: :issue:`1827`, PR: :issue:`1929`)
+
+- Turn off strict parsing of ``*.pls`` playlist files. This was a regression
+  that happened during the migration to Python 3. (PR: :issue:`1923`)
+
+- Make the systemd unit that ships with Mopidy wait for an Internet
+  connection before starting Mopidy. When used by distribution packages, this
+  can help avoid that extensions try to connect to cloud services before the
+  machine's Internet connection is ready for use. (PR: :issue:`1946`)
+
+
 v3.0.2 (2020-04-02)
 ===================
 

docs/codestyle.rst

@@ -10,6 +10,8 @@ All projects in the Mopidy organization follows the following code style:
   Use Black's string normalization, which prefers ``"`` quotes over ``'``,
   unless the string contains ``"``.
 
+- Automatically sort imports using `isort <https://timothycrosley.github.io/isort>`_.
+
 - Follow :pep:`8`.
   Run `flake8 <https://pypi.org/project/flake8>`_  to check your code
   against the guidelines.