Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: library.lookup should unwrap streams #1445

Closed
adamcik opened this issue Feb 14, 2016 · 1 comment
Closed

stream: library.lookup should unwrap streams #1445

adamcik opened this issue Feb 14, 2016 · 1 comment
Assignees
@adamcik
Labels
C-bug Category: This is a bug
Milestone
v2.0 - Gapless an...

Comments

@adamcik
Copy link
Member

adamcik commented Feb 14, 2016

It turns out we've forgotten to do the unwrap stream step for the library provider. Thanks to @tkem for noticing :-)
@adamcik adamcik added the C-bug Category: This is a bug label Feb 14, 2016
trygveaa added a commit to trygveaa/mopidy that referenced this issue Feb 14, 2016
@trygveaa
stream: Unwrap uri in stream library lookup
c5cd501 
This makes lookup work properly for playlists. This is sort of a quick
fix as _unwrap_stream does some scanning which is not necessary for
lookup.

Fixes mopidy#1445.
@trygveaa trygveaa mentioned this issue Feb 14, 2016
Closed
trygveaa added a commit to trygveaa/mopidy that referenced this issue Feb 14, 2016
@trygveaa
stream: Unwrap uri in stream library lookup
89c99e9 
This makes lookup work properly for playlists. This is sort of a quick
fix as _unwrap_stream does some scanning which is not necessary for
lookup.

Fixes mopidy#1445.
@adamcik
Copy link
Member Author

adamcik commented Feb 14, 2016

Other catch is that _unwrap_stream doesn't respect the blacklist. So any songs with one time tokens would break. I thin we want to actually share all the logic between the translate and lookup cases to make this sane.

@jodal jodal closed this as completed in 2e5cfba Feb 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamcik adamcik

Labels
C-bug Category: This is a bug
Projects
None yet
Milestone
v2.0 - Gapless and GStreamer 1.x
Development

Successfully merging a pull request may close this issue.

stream: Unwrap uri in stream library lookup trygveaa/mopidy
1 participant
@adamcik