Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueError from bad audio tags #1506

Closed
jmsaaren opened this issue May 8, 2016 · 2 comments
Closed

ValueError from bad audio tags #1506

jmsaaren opened this issue May 8, 2016 · 2 comments
Labels
C-bug Category: This is a bug

Comments

@jmsaaren
Copy link

jmsaaren commented May 8, 2016

audio/tags.py:

def convert_taglist(taglist):
...
date = datetime.date(
value.get_year(), value.get_month(), value.get_day())

This raises a ValueError that is not catched when audio track has badly set year.
I suggest that if the year exceeds datetime.MAXYEAR then use datetime.MAXYEAR or 0 as the audio itself is probably not broken.

@jodal jodal added the C-bug Category: This is a bug label May 9, 2016
@jodal jodal added this to the v2.0.1 - Bug fixes milestone May 9, 2016
@sticken88
Copy link

Could you please write the steps to reproduce it?

@palfrey
Copy link
Contributor

palfrey commented Jun 10, 2016

I've just created a PR #1525 that reproduces this problem in a test and fixes it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug
Projects
None yet
Development

No branches or pull requests

4 participants