Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing stream_title_changed events #1746

Closed
kingosticks opened this issue Feb 15, 2019 · 1 comment
Closed

Missing stream_title_changed events #1746

kingosticks opened this issue Feb 15, 2019 · 1 comment
Assignees
Labels
A-core Area: Core layer C-bug Category: This is a bug
Milestone

Comments

@kingosticks
Copy link
Member

As part of trying to improve the support for stream titles in Musicbox-Webclient I see that Mopidy only emits the stream_title_changed event if the 'organization' tag is present.

mopidy/mopidy/core/actor.py

Lines 134 to 137 in 99d8a21

# TODO: this limits us to only streams that set organization, this is
# a hack to make sure we don't emit stream title changes for plain
# tracks. We need a better way to decide if something is a stream.
if 'title' in tags and tags['title'] and 'organization' in tags:

Sadly, this tag isn't set for some of the streams I tried. This issue is closely related to, and would be fixed by, #270 and #1138 but maybe could be solved without those. One improvement might be to suppress the title tag if the tack has a non-zero duration instead?

@kingosticks kingosticks added C-bug Category: This is a bug A-core Area: Core layer labels Feb 15, 2019
@kingosticks
Copy link
Member Author

Or only suppress it when the title matches the current track name. That actually sounds quite good to me.

kingosticks added a commit to kingosticks/mopidy that referenced this issue Mar 12, 2019
kingosticks added a commit to kingosticks/mopidy that referenced this issue Sep 9, 2019
kingosticks added a commit to kingosticks/mopidy that referenced this issue Sep 9, 2019
kingosticks added a commit to kingosticks/mopidy that referenced this issue Sep 9, 2019
kingosticks added a commit to kingosticks/mopidy that referenced this issue Sep 10, 2019
kingosticks added a commit to kingosticks/mopidy that referenced this issue Sep 11, 2019
kingosticks added a commit to kingosticks/mopidy that referenced this issue Sep 11, 2019
@kingosticks kingosticks modified the milestones: v2.2.4, v2.3.0 Sep 26, 2019
@jodal jodal closed this as completed in dae56b4 Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core layer C-bug Category: This is a bug
Projects
None yet
Development

No branches or pull requests

1 participant