mopidy-scan not using correct LOCAL_MUSIC_PATH default

[jodal]

~/music exists and got music in it. LOCAL_MUSIC_PATH is not set in my settings file, i.e. it should default to ~/music.

$ PYTHONPATH=. ./bin/mopidy-scan 
INFO     2012-09-11 15:56:32,431 [15354:MainThread] root
  Scanning None
Traceback (most recent call last):
  File "./bin/mopidy-scan", line 26, in <module>
    scanner = Scanner(settings.LOCAL_MUSIC_PATH, store, debug)
  File "/home/jodal/dev/mopidy/mopidy/scanner.py", line 55, in __init__
    self.uris = [path_to_uri(f) for f in find_files(folder)]
  File "/home/jodal/dev/mopidy/mopidy/utils/path.py", line 53, in find_files
    if os.path.isfile(path):
  File "/home/jodal/dev/virtualenvs/mopidy/lib/python2.7/genericpath.py", line 29, in isfile
    st = os.stat(path)
TypeError: coercing to Unicode: need string or buffer, NoneType found

[adamcik]

~/.config/user-dirs.locale's XDG_MUSIC_DIR entry might be better default. Though on my system it is currently just set to ~. Could you test running xdg-user-dir MUSIC and tell me what it says?

[adamcik]

I would suggest we default to glib.get_user_special_dir(glib.USER_DIRECTORY_MUSIC) when LOCAL_MUSIC_PATH is None.

[jodal]

$ xdg-user-dir MUSIC
/home/jodal/

Note that I've deleted all the default Ubuntu dirs, except Desktop and Downloads.

As long as we don't scan dotfiles directories, I don't think using the home dir as default value is a problem.

[jodal]

Fixed by PR #200.