Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a "global" playlist mapping in MPD dispatch code #934

Closed
adamcik opened this issue Jan 13, 2015 · 1 comment
Closed

Use a "global" playlist mapping in MPD dispatch code #934

adamcik opened this issue Jan 13, 2015 · 1 comment
Assignees
@kingosticks
Labels
C-enhancement Category: A PR with an enhancement or an issue with an enhancement proposal good first issue Call for participation
Milestone
v1.0 - Audio clea...

Comments

@adamcik
Copy link
Member

adamcik commented Jan 13, 2015

https://discuss.mopidy.com/t/mpc-clients-are-slow-to-connect-to-git-version-of-mopidy/518 has some of the backstory. But the short version is that redoing this mapping for users with many spotify playlists is costly (and can lead to inconsistencies).

So we should be caching this or just moving it up to the server level instead of doing this once per session / connection.
@adamcik adamcik added MPD C-enhancement Category: A PR with an enhancement or an issue with an enhancement proposal labels Jan 13, 2015
@kingosticks kingosticks added the good first issue Call for participation label Jan 13, 2015
@kingosticks kingosticks mentioned this issue Jan 13, 2015
Closed
@kingosticks kingosticks mentioned this issue Jan 27, 2015
Closed
@jodal jodal added this to the v0.20 - Audio cleanup 1 milestone Feb 5, 2015
@kingosticks kingosticks mentioned this issue Feb 9, 2015
Merged
@jodal
Copy link
Member

jodal commented Feb 9, 2015

Fixed by PR #968

@jodal jodal added 3 - Done and removed 2 - Working labels Feb 9, 2015
@jodal jodal closed this as completed Feb 9, 2015
@jodal jodal removed the 3 - Done label Feb 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kingosticks kingosticks

Labels
C-enhancement Category: A PR with an enhancement or an issue with an enhancement proposal good first issue Call for participation
Projects
None yet
Milestone
v1.0 - Audio cleanup 1
Development

No branches or pull requests
3 participants
@jodal @adamcik @kingosticks