Port to GStreamer 1.x and PyGI #1419
Conversation
It was a workaround for icy:// support on GStreamer 0.10.
GStreamer no longer use sys.argv directly. If you want GStreamer to handle command line arguments, you must pass them explicitly to Gst.init().
And audio/x-raw-int and audio/x-raw-float with audio/x-raw
| Audio | ||
| ----- | ||
|
|
||
| - **Breaking:** The audio scanner now returns ISO-8601 formatted strings |
There was a problem hiding this comment.
@tkem this one is probably relevant for you with respect to mopidy-local-sqlite. Other uses of the scanner is mostly tunein and the likes, @kingosticks I presume this won't effect that code?
There was a problem hiding this comment.
I think I looked into Mopidy-Local-* at some point looking for issues with this without finding anything, but it would be great if @tkem checked himself.
There was a problem hiding this comment.
I don't think Tunein is using the Scanner instance it creates any more. Looks like it's in a bit of a state after that last PRs I merged. So no, no issue there.
There was a problem hiding this comment.
mopidy-local-sqlite doesn't use the audio scanner directly, but only uses the Track as passed by the local library interface.
mopidy-local-images does use the tags from the audio scanner, but only looks for image and preview-image tags.
So there shouldn't be any issues.
There was a problem hiding this comment.
We should be all good then. Mopidy-Spotify is the only extension that needs a new release to work with Mopidy 1.2 (which in semver should be named 2.0, but, well, we control the only thing that is broken).
|
Think that is it for this round. |
If GStreamer is too old, it fails like this: $ mopidy ERROR: Mopidy requires GStreamer >= 1.2, but found GStreamer 1.0.0.
|
I think that addressed all comments, if you add your |
|
|
||
| audio/x-raw,format=S16LE,rate=44100,channels=2,layout=interleaved | ||
|
|
||
| If you Mopidy backend uses ``set_appsrc()``, please refer to GStreamer |
|
|
||
| :param taglist: A GStreamer taglist to be converted. | ||
| :type taglist: :class:`Gst.TagList` | ||
| :rtype: dictionary of tag keys with a list of values. |
There was a problem hiding this comment.
Don't we normally express returning dictionaries as {tag: list of plain Python types} ?
There was a problem hiding this comment.
As soon as we get to Python 3 only (Mopidy 3.0?) I want to replace all of these rtype declarations with optional typing, e.g. Dict[str, List]. For now, I'm not sure we have a clear convention.
This pull request is identical to what we've had in the
feature/gst1branch the last few weeks, just rebased on top of develop.It switches Mopidy from GStreamer 0.10 to 1.2+ and the GStreamer Python bindings from PyGST to PyGI. (Fixes #225)
On a related note, this is the last major blocker for running Mopidy on Python 3, ref. #779.