Fix errors and warnings when importing Gst with gst-python >= 1.5.2 #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of gst-python 1.5.2, the init call requires one argument. The argument is a list of the command line options. I don't think we need to send any. This relates to mopidy#1432.
As of gst-python 1.5.2, Gst.is_initialized throws a NotInitialized exception if run before Gst.init. Gst.init should be a noop if run again after the first call, so this should be safe. This fixes mopidy#1432.
With gst-python 1.6.2, importing GstPbutils before calling Gst.init gives some warnings.
|
Someone with gst-python < 1.5.2 (e.g. Debian Jessie or Ubuntu), please test this. |
|
Hm, I still get this warning from time to time with this branch as well. Though, most of the time, I don't get it. The same is the case for the develop branch. |
jodal
added a commit
that referenced
this pull request
Feb 8, 2016
Fix errors and warnings when importing Gst with gst-python >= 1.5.2
|
We should probably open upstream bugs about that:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With gst-python >= 1.5.2, a NotInitialized exception is thrown if Gst.is_initialized is called before Gst.init. This removes the Gst.is_initialized check, as Gst.init should be a noop if run again after the first call. This also adds an argument to Gst.init as gst-python >= 1.5.2 requires that as well.
Additionally, after fixing that, I got some warnings when importing GstPbutils before calling Gst.init, so that import is moved below the init, which removed the warnings.
This fixes #1432.